public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm_cortexa8: support cache flush to other soc
Date: Tue, 08 Sep 2009 20:51:56 +0200	[thread overview]
Message-ID: <4AA6A7CC.6050907@googlemail.com> (raw)
In-Reply-To: <4AA5A986.8060003@windriver.com>

Tom wrote:
> Minkyu Kang wrote:
>> Dear Dirk,
>>
>>
> <snip>
> 
> I have lost track of this thread.

Yes, and I'm currently trying to get the track back ;)

> When last I worked this, it seemed like the cache routines were going to
> be split.
> 
> 1. generic cache routines
> 2. legacy soc cache routines.
> 
> Are the generic cache routines in place and can you use them?
> Else can you handle your soc specific cache routines as part of a
> legacy cache routine ?
> 
> The omap cache routines are dependent on omap rom code and fitting
> new routines in using the omap specifics may not be the best way to
> go.

I'm sure this is not the perfect way, but it seems to me that 
splitting all this stuff into several small steps would be the easier 
for all. E.g.

1) From the previous discussion I think we should apply

http://lists.denx.de/pipermail/u-boot/2009-August/058492.html

Independent of any discussion if this code is needed at all, if it is 
generic or not etc. the main advantage I understood is that it frees 
the way for Samsung.

2a) Then, what I understood from Minkyu, we need an additional patch 
(discussion?) how to switch CONFIG_L2_OFF from compile time to run 
time selection (for Samsung's multi board support)

2b) Then, what I understood from Minkyu, we should discuss about 
removal of get_device_type() function

3) In parallel, we should discuss how to further improve the OMAP3 
cache stuff. What might be generic, what not, what isn't necessary etc.

4) Regarding (cache) code duplication, I vote for doing this 
duplication first. That is, have working Samsung and OMAP3 code 
applied in parallel. While Jean-Christophe might cry "code 
duplication", I learned from OMAP3 boards that is was easier to unify 
common code _after_ code duplication was done and therefore can be 
easily identified. Discussing about possible code duplication without 
being able to see (and test) the code is sometimes a little tricky ;)

As mentioned, doing this in several, small steps I feel more 
comfortable with. If we would have done step (1) already, it's my 
feeling that we would have reached step 2 or 3 already. But now, we 
are still discussing about the 'one big perfect patch'.

Best regards

Dirk

  reply	other threads:[~2009-09-08 18:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04  8:26 [U-Boot] [PATCH] arm_cortexa8: support cache flush to other soc Minkyu Kang
2009-09-04  8:43 ` Dirk Behme
2009-09-04  9:34   ` Kyungmin Park
2009-09-04 10:45     ` Dirk Behme
2009-09-04 10:54       ` Kyungmin Park
2009-09-04 11:43         ` Dirk Behme
2009-09-04 14:29           ` Minkyu Kang
2009-09-04 15:06             ` Dirk Behme
2009-09-07  1:31               ` Minkyu Kang
2009-09-07 16:52                 ` Dirk Behme
2009-09-08  0:06                   ` Minkyu Kang
2009-09-08  0:47                     ` Tom
2009-09-08 18:51                       ` Dirk Behme [this message]
2009-09-08 22:23                         ` Tom
2009-09-09  5:34                           ` Minkyu Kang
2009-09-09 11:24                             ` Tom
2009-09-09 12:04                               ` Minkyu Kang
2009-09-10 19:02                           ` Tom
2009-09-10 19:36                             ` Paulraj, Sandeep
2009-09-04 22:24       ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-04 11:06     ` Wolfgang Denk
2009-09-04 11:11       ` Kyungmin Park
2009-09-04 11:48         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA6A7CC.6050907@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox