From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
Date: Tue, 08 Sep 2009 14:09:43 -0500 [thread overview]
Message-ID: <4AA6ABF7.5060709@windriver.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D925680C6@dlee01.ent.ti.com>
Paulraj, Sandeep wrote:
>
>> -----Original Message-----
>> From: Wolfgang Denk [mailto:wd at denx.de]
>> Sent: Tuesday, September 08, 2009 2:51 PM
>> To: Paulraj, Sandeep
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
>>
>> Dear s-paulraj at ti.com,
>>
>> In message <1252434246-19517-1-git-send-email-s-paulraj@ti.com> you wrote:
>>> From: Sandeep Paulraj <s-paulraj@ti.com>
>>>
>>> This patch removes the asm/sizes.h header file from being
>>> included in the DaVinci SOC configs.
>>> References to SZ_xx have been replaced by appropriate
>>> bit shifted values.
>>>
>>> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
>> Note that this patch actually changes the configuration:
>>
>>> --- a/include/configs/davinci_dm355evm.h
>>> +++ b/include/configs/davinci_dm355evm.h
>> ...
>>> /* U-Boot memory configuration */
>>> -#define CONFIG_STACKSIZE SZ_256K /* regular stack */
>>> -#define CONFIG_SYS_MALLOC_LEN SZ_512K /* malloc()
>> arena */
>>> +#define CONFIG_STACKSIZE (256 << 10) /* 256 KiB */
>>> +#define CONFIG_SYS_MALLOC_LEN (1 << 20) /* 1 MiB*/
>> as it increases the malloc() arena size form 512 to 1024 KiB.
>>
>> Assuming this was done intentionally:
> [Sandeep] Yes this was intentional because for NANDs with large block sizes(256 KiB), if this is not increased we will get "out of memory" errors.
>> Acked-by: Wolfgang Denk <wd@denx.de>
>>
Then this change needs to be a separate patch.
Nak Tom
next prev parent reply other threads:[~2009-09-08 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 18:24 [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx s-paulraj at ti.com
2009-09-08 18:50 ` Wolfgang Denk
2009-09-08 18:56 ` Paulraj, Sandeep
2009-09-08 19:04 ` Paulraj, Sandeep
2009-09-08 20:34 ` Wolfgang Denk
2009-09-08 19:09 ` Tom [this message]
2009-09-08 19:14 ` J.C. Wren
2009-09-08 19:20 ` Paulraj, Sandeep
2009-09-08 19:28 ` J.C. Wren
2009-09-08 19:38 ` Paulraj, Sandeep
2009-09-08 20:07 ` Jerry Van Baren
2009-09-08 20:12 ` J.C. Wren
2009-09-08 20:41 ` Wolfgang Denk
2009-09-08 21:13 ` Jerry Van Baren
2009-09-08 21:21 ` Wolfgang Denk
2009-09-09 2:45 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA6ABF7.5060709@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox