From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Tue, 08 Sep 2009 17:13:55 -0400
Subject: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
In-Reply-To: <20090908204114.E79F9832E8DE@gemini.denx.de>
References: <1252434246-19517-1-git-send-email-s-paulraj@ti.com>
	<20090908185057.CDC1A832E8DE@gemini.denx.de>
	<0554BEF07D437848AF01B9C9B5F0BC5D925680C6@dlee01.ent.ti.com>
	<4AA6ABF7.5060709@windriver.com>
	<17434f2e0909081214tf30f005tb4f1086461198e7a@mail.gmail.com>
	<0554BEF07D437848AF01B9C9B5F0BC5D9256816F@dlee01.ent.ti.com>
	<17434f2e0909081228g626feae2s1bac3bbcedabd2c6@mail.gmail.com>
	<4AA6B98B.2040502@ge.com>
	<17434f2e0909081312r3fe4523ej66ed4fc0275fa148@mail.gmail.com>
	<20090908204114.E79F9832E8DE@gemini.denx.de>
Message-ID: <4AA6C913.7000004@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear "J.C. Wren",
> 
> In message <17434f2e0909081312r3fe4523ej66ed4fc0275fa148@mail.gmail.com> you wrote:
>> Excellent explanation.  Thank you.
> 
> Indeed. Thanks to gvb.
> 
> I'd just like to add that you also never know if SZ_1M is 1024*1024 or 1000*1000.
> 
>> I do like this (from the email link): (31 * 1024 * 1024).  And it appears
>> not to give Wolfgang indigestion :)
> 
> It is probably the preferred form in many cases, line length
> permitting :-) "31 << 20" is a bit shorter, but it's just a personal

s/3// ;-)

> preference, not something I consider better in any way.
> 
> Best regards,
> 
> Wolfgang Denk

Another objection: Company A makes their favorite SZ_* defines but 
Company B defines them as SIZE_* but Company C defines them as...

...and we end up with the same mess as INT32 vs. WORD vs. int32_t 
defines (C99 tackled that, finally, but not all the mess has been 
cleaned up yet, 10 years later).

Best regards,
gvb