[U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx

J.C. Wren
2009-09-08T19:28:14Z

I saw this comment: "Also i gather from e-mails on the list that Wolfgang
does not like these references to "SZ_xx". Maybe that discussion took place
before I joined the list.

If he wants it that way, fine. But that doesn't explain the "why". What's
so offensive about the SZ_* defines?

--jc

On Tue, Sep 8, 2009 at 3:20 PM, Paulraj, Sandeep <s-paulraj@ti.com> wrote:

> Jc,
>
>
>
> Did you read what I wrote below the --- line in the patch itself?
>
>
>
> Wolfgang wants to get rid of these references. He expressed this some time
> back.
>
> If he decides to get rid of this file altogether this will lead to
> compilation failures.
>
>
>
> Thanks,
>
> Sandeep
>
>
> ------------------------------
>
> *From:* jcwren at gmail.com [mailto:jcwren at gmail.com] *On Behalf Of *J.C.
> Wren
> *Sent:* Tuesday, September 08, 2009 3:15 PM
> *To:* Tom
> *Cc:* Paulraj, Sandeep; u-boot at lists.denx.de
>
> *Subject:* Re: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
>
>
>
> Why is this change being made at all? Seems a lot more awkward to define
> (1 << 20) than SZ_1MB. SZ_1MB reads a lot easier.
>
> --jc
>
> On Tue, Sep 8, 2009 at 3:09 PM, Tom <Tom.Rix@windriver.com> wrote:
>
> Paulraj, Sandeep wrote:
> >
> >> -----Original Message-----
> >> From: Wolfgang Denk [mailto:wd at denx.de]
> >> Sent: Tuesday, September 08, 2009 2:51 PM
> >> To: Paulraj, Sandeep
> >> Cc: u-boot at lists.denx.de
> >> Subject: Re: [U-Boot] [PATCH] TI DaVinci: Remove references to SZ_xx
> >>
> >> Dear s-paulraj at ti.com,
> >>
> >> In message <1252434246-19517-1-git-send-email-s-paulraj@ti.com> you
> wrote:
> >>> From: Sandeep Paulraj <s-paulraj@ti.com>
> >>>
> >>> This patch removes the asm/sizes.h header file from being
> >>> included in the DaVinci SOC configs.
> >>> References to SZ_xx have been replaced by appropriate
> >>> bit shifted values.
> >>>
> >>> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> >> Note that this patch actually changes the configuration:
> >>
> >>> --- a/include/configs/davinci_dm355evm.h
> >>> +++ b/include/configs/davinci_dm355evm.h
> >> ...
> >>> /* U-Boot memory configuration */
> >>> -#define CONFIG_STACKSIZE SZ_256K /* regular stack */
> >>> -#define CONFIG_SYS_MALLOC_LEN SZ_512K /* malloc()
> >> arena */
> >>> +#define CONFIG_STACKSIZE (256 << 10) /* 256 KiB */
> >>> +#define CONFIG_SYS_MALLOC_LEN (1 << 20) /* 1 MiB*/
> >> as it increases the malloc() arena size form 512 to 1024 KiB.
> >>
> >> Assuming this was done intentionally:
> > [Sandeep] Yes this was intentional because for NANDs with large block
> sizes(256 KiB), if this is not increased we will get "out of memory" errors.
> >> Acked-by: Wolfgang Denk <wd@denx.de>
> >>
>
> Then this change needs to be a separate patch.
>
> Nak Tom
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>