public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mucmc52, uc101: delete ata@3a00 node, if no CF card is detected
Date: Wed, 09 Sep 2009 11:12:12 +0200	[thread overview]
Message-ID: <4AA7716C.3000003@denx.de> (raw)
In-Reply-To: <20090909083837.439E4832E8DE@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <4AA755D4.1020207@denx.de> you wrote:
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>  board/mucmc52/mucmc52.c |   15 +++++++++++++++
>>  board/uc101/uc101.c     |   15 +++++++++++++++
>>  2 files changed, 30 insertions(+), 0 deletions(-)
> 
> Hmm... that looks like duplicated identical code to me. Maybe we can
> move this into a central location instead?

Hmm.. you are right, maybe cpu/mpc5xxx/cpu.c ft_cpu_setup() is
a better place for it. And we can activate this through an
CONFIG_OF_IDE_FIXUP define.

Comments?

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-09-09  9:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09  7:14 [U-Boot] [PATCH 2/2] mucmc52, uc101: delete ata@3a00 node, if no CF card is detected Heiko Schocher
2009-09-09  8:38 ` Wolfgang Denk
2009-09-09  9:12   ` Heiko Schocher [this message]
2009-09-09  9:03     ` Wolfgang Denk
2009-09-10  5:56       ` [U-Boot] [PATCHv2 " Heiko Schocher
2009-09-14 13:07         ` Detlev Zundel
2009-09-14 15:06           ` Heiko Schocher
2009-09-14 15:06           ` [U-Boot] [PATCH v4 " Heiko Schocher
2009-09-14 15:03             ` Stefan Roese
2009-09-14 15:26               ` Heiko Schocher
2009-09-14 15:29                 ` Stefan Roese
2009-09-14 15:55                   ` Heiko Schocher
2009-09-14 15:44                     ` Stefan Roese
2009-09-14 16:04                       ` Heiko Schocher
2009-09-14 15:08             ` Stefan Roese
2009-09-14 15:36               ` Heiko Schocher
2009-09-14 15:09             ` Jerry Van Baren
2009-09-14 15:38               ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA7716C.3000003@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox