From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 09 Sep 2009 11:12:12 +0200 Subject: [U-Boot] [PATCH 2/2] mucmc52, uc101: delete ata@3a00 node, if no CF card is detected In-Reply-To: <20090909083837.439E4832E8DE@gemini.denx.de> References: <4AA755D4.1020207@denx.de> <20090909083837.439E4832E8DE@gemini.denx.de> Message-ID: <4AA7716C.3000003@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Wolfgang Denk wrote: > In message <4AA755D4.1020207@denx.de> you wrote: >> Signed-off-by: Heiko Schocher >> --- >> board/mucmc52/mucmc52.c | 15 +++++++++++++++ >> board/uc101/uc101.c | 15 +++++++++++++++ >> 2 files changed, 30 insertions(+), 0 deletions(-) > > Hmm... that looks like duplicated identical code to me. Maybe we can > move this into a central location instead? Hmm.. you are right, maybe cpu/mpc5xxx/cpu.c ft_cpu_setup() is a better place for it. And we can activate this through an CONFIG_OF_IDE_FIXUP define. Comments? bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany