From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 10 Sep 2009 14:45:05 +0200 Subject: [U-Boot] [PATCHv2 1/2] mpc52xx, mucmc52, uc101: config cleanup In-Reply-To: References: <4AA755CD.8050807@denx.de> <20090909120529.0F9E3832E8DE@gemini.denx.de> <4AA89502.1070809@invitel.hu> Message-ID: <4AA8F4D1.8000302@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Detlev, Detlev Zundel wrote: >> - as this boards are similiar, collect common config option >> in manroland-common.h and manroland-mpc52xx-common.h >> for mpc52xx specific common options for this manufacturer. >> - add OF support >> - update default environment > > Argh, sorry for interrupting again, but I think I suggested something > problematic on second thought: > >> include/configs/manroland-mpc52xx-common.h | 230 ++++++++++++++++++++++++ > > [...] > >> diff --git a/include/configs/manroland-mpc52xx-common.h b/include/configs/manroland-mpc52xx-common.h >> new file mode 100644 >> index 0000000..b29ef9b >> --- /dev/null >> +++ b/include/configs/manroland-mpc52xx-common.h > > [...] > >> +#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ >> +#define CONFIG_MPC5200 1 /* (more precisely an MPC5200 CPU) */ > > So all boards using manroland-mpc52xx-common.h are in fact 5200s. In > this case, I should have suggested the filename > "manroland-mpc5200-common.h" as the "xx" part surely cannot be anything > else then "00". Argh.. and I didn;t detected it too ;-) > Sorry for this wrong lead. No problem, I send a patch soon, if the rest of this patch is ok. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany