public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Fix problem with 405EZ ethernet interrupt
Date: Thu, 10 Sep 2009 16:03:31 -0700	[thread overview]
Message-ID: <4AA985C3.5060901@gmail.com> (raw)
In-Reply-To: <1252566710-10101-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> From: James Clough <james@rtetc.com>
>
> On 405EZ the RX-/TX-interrupts are coalesced into one IRQ bit in the
> UIC. We need to acknowledge the RX-/TX-interrupts in the
> SDR0_ICINTSTAT reg as well.
>
> This problem was introduced with commit
> d1631fe1 [ppc4xx: Consolidate PPC4xx UIC defines]
>
> Signed-off-by: James Clough <james@rtetc.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/net/4xx_enet.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/4xx_enet.c b/drivers/net/4xx_enet.c
> index 329eef0..9d438b5 100644
> --- a/drivers/net/4xx_enet.c
> +++ b/drivers/net/4xx_enet.c
> @@ -1717,6 +1717,15 @@ int enetInt (struct eth_device *dev)
>  				rc = 0;
>  			}
>  		}
> +#if defined(CONFIG_405EZ)
> +		/*
> +		 * On 405EZ the RX-/TX-interrupts are coalesced into
> +		 * one IRQ bit in the UIC. We need to acknowledge the
> +		 * RX-/TX-interrupts in the SDR0_ICINTSTAT reg as well.
> +		 */
> +		mtsdr(SDR0_ICINTSTAT,
> +		      SDR_ICRX_STAT | SDR_ICTX0_STAT | SDR_ICTX1_STAT);
> +#endif  /* defined(CONFIG_405EZ) */
>  	} while (serviced);
>  
>  	return (rc);
>   
Applied to net repo.

thanks,
Ben

  reply	other threads:[~2009-09-10 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10  7:11 [U-Boot] [PATCH] net: Fix problem with 405EZ ethernet interrupt Stefan Roese
2009-09-10 23:03 ` Ben Warren [this message]
2009-10-04 19:09   ` Wolfgang Denk
2009-10-04 22:08     ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA985C3.5060901@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox