From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
Date: Thu, 10 Sep 2009 20:11:20 -0500 [thread overview]
Message-ID: <4AA9A3B8.5030806@windriver.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D9267EB4C@dlee01.ent.ti.com>
Paulraj, Sandeep wrote:
>> v7_flush_dcache_all, because it depends on omap ROM code is not
>> generic. Rename the function to 'invalidate_dcache' and move it
>> to the omap cpu directory.
>>
>> Collect the other omap cache routines l2_cache_enable and
>> l2_cache_disable with invalide_dcache into cache.S. This
>> means removing the old cache.c file that contained l2_cache_enable
>> and l2_cache_disable.
>>
>> The conversion from cache.c to cache.S was done most through
>> disassembling the uboot binary. The only significant change was
>> to change the comparision for the return of get_cpu_rev from
>>
>> cmp r0, #0
>> beq earlier_than_label
>>
>> Which was lost information to
>>
>> cmp r0, #CPU_3XX_ES20
>> blt earlier_than_label
>>
>> The paths through the enable routine were verified by
>> adding an infinite loop and seeing the hang. Then
>> removing the infinite loop and seeing it continue.
>>
>> The disable routine is similar enough that it was not
>> tested with this method.
>>
>> Run tested by cold booting from nand on beagle and zoom1.
>> Compile tested on MAKEALL arm.
>>
>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>> ---
>> cpu/arm_cortexa8/cpu.c | 2 +-
>> cpu/arm_cortexa8/omap3/Makefile | 2 +-
>> cpu/arm_cortexa8/omap3/board.c | 2 +-
>> cpu/arm_cortexa8/omap3/cache.S | 191
>> ++++++++++++++++++++++++++++++++
>> cpu/arm_cortexa8/omap3/cache.c | 95 ----------------
>> cpu/arm_cortexa8/start.S | 85 --------------
>> include/asm-arm/arch-omap3/omap3.h | 2 +
>> include/asm-arm/arch-omap3/sys_proto.h | 2 +-
>> 8 files changed, 197 insertions(+), 184 deletions(-)
>> create mode 100644 cpu/arm_cortexa8/omap3/cache.S
>> delete mode 100644 cpu/arm_cortexa8/omap3/cache.c
>
> Applied to u-boot-ti
>
> -Sandeep
Thanks!
I am traveling tomorrow and I will pull it this weekend.
Tom
prev parent reply other threads:[~2009-09-11 1:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:42 [U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix
2009-08-12 15:42 ` [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S Tom Rix
2009-08-12 16:35 ` Dirk Behme
2009-08-12 21:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-12 22:38 ` Tom
2009-08-12 21:49 ` Wolfgang Denk
2009-08-12 22:17 ` Tom
2009-09-10 23:39 ` Paulraj, Sandeep
2009-09-11 1:11 ` Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA9A3B8.5030806@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox