From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 14 Sep 2009 14:47:47 +0200 Subject: [U-Boot] [PATCH v2 1/2] mkconfig: split the board make target to multiple config targets In-Reply-To: <20090911080746.5CAA4832E8DE@gemini.denx.de> References: <1252466603-25103-1-git-send-email-Mingkai.hu@freescale.com> <20090911080746.5CAA4832E8DE@gemini.denx.de> Message-ID: <4AAE3B73.5030400@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Mingkai Hu, > > In message <1252466603-25103-1-git-send-email-Mingkai.hu@freescale.com> you wrote: >> To simplify the top level makefile it useful to be able to parse >> the top level makefile target to multiple individual target, then >> put them to the config.h, leave the board config file to handle >> the different targets. >> >> Note that this method uses the '_'(underline) as the delimiter when >> splits the board make target. >> >> Signed-off-by: Mingkai Hu >> --- >> >> According to the comments from Wolfgang and Scott, I modified >> the patch and made some modification over v1: >> >> - remove the sectence thats puts the splited variables to the >> config.mk, we can use the CONFIG_MK_* in the board config file >> to override the variable in the board config file. >> >> - change CONFIG_OPT_* to CONFIG_MK_* >> >> mkconfig | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) > > Arghhh... It seems this patch has not been well tested. Obviously > never ever ran a MAKEALL over all PPC boards. It causes tons of > messages like that: > > include/config.h:2:25: warning: missing whitespace after the macro name > > This patch breaks building for a number of boards / configurations, > especially: > > xilinx-ppc405-generic_flash > xilinx-ppc405-generic > xilinx-ppc440-generic_flash > xilinx-ppc440-generic > VoVPN-GW_66MHz > VoVPN-GW_100MHz > EB+MCF-EV123 > EB+MCF-EV123_internal > microblaze-generic I can confirm problem on Microblaze. Please revert that patches. Thanks, Michal > favr-32-ezkit > > > Shall I revert that patch? > > Best regards, > > Wolfgang Denk > -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian