public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <menon.nishanth@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] DLMALLOC:!X86: add av_ initialization
Date: Sat, 19 Sep 2009 10:37:58 -0500	[thread overview]
Message-ID: <4AB4FAD6.20002@gmail.com> (raw)
In-Reply-To: <1253368999.27060.6.camel@ptyser-laptop>

Peter Tyser said the following on 09/19/2009 09:03 AM:
> On Fri, 2009-09-18 at 21:21 -0500, Nishanth Menon wrote:
>   
>> This is questionable if this is really required
>> as the av_ static initalized values should have
>> been loaded to sdram as part of the boot process
>> and initialization should have been done.
>>     
>
> Is there a reason you need to do this fixup?  Based on your commit
> message its unclear if this patch is really needed...
>
>   
Essentially, the loaded memory from the NOR looks all corrupted.
I am unable to convince myself why the SDRAM is not updated
with the static default inits - SDRAM corruption would have
cracked everything else and scope measurement looks good too.
>> Signed-off-by: Nishanth Menon <nm
>>  void mem_malloc_init(ulong start, ulong size)
>>  {
>> +	u8 i;
>> +	av_[0] = av_[1] = 0;
>> +	for (i = 0; i < 128; i++)
>> +		av_[2 + i * 2] = av_[2 + i * 2 + 1] = bin_at(i);
>> +
>>  	mem_malloc_start = start;
>>  	mem_malloc_end = start + size;
>>  	mem_malloc_brk = start;
>>     
>
> If you are going to do this fixup, av_ should not be initialized with
> values (you're currently doing the same initialization 2 times).  In
> general, we could probably shave a bit off of U-Boot's size by leaving
> av_ uninitialized and implementing your manual calculation of av_ above,
>   
yep.. missed finishing that out.. :(
> but I'm not sure why this change should be included in this patch
> series.
>   
This patch is need for booting SDP3430 from NOR flash.

Regards,
Nishanth Menon

  reply	other threads:[~2009-09-19 15:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-19  2:21 [U-Boot] [PATCH 0/6] ARM:OMAP3:SDP3430 initial support Nishanth Menon
2009-09-19  2:21 ` [U-Boot] [PATCH 1/6] OMAP3: Fix SDRC init Nishanth Menon
2009-09-19  2:21   ` [U-Boot] [PATCH 2/6] OMAP3: export enable_gpmc_cs_config to board files Nishanth Menon
2009-09-19  2:21     ` [U-Boot] [PATCH 3/6] OMAP3: make gpmc_config as const Nishanth Menon
2009-09-19  2:21       ` [U-Boot] [PATCH 4/6] OMAP3: fix warnings when NAND/ONENAND is not used Nishanth Menon
2009-09-19  2:21         ` [U-Boot] [PATCH 5/6] DLMALLOC:!X86: add av_ initialization Nishanth Menon
2009-09-19  2:21           ` [U-Boot] [PATCH 6/6] ARM:OMAP3:SDP3430: initial support Nishanth Menon
2009-09-19 14:34             ` Peter Tyser
2009-09-19 15:43               ` Nishanth Menon
2009-09-20  1:27               ` Paulraj, Sandeep
2009-09-23 19:51             ` Wolfgang Denk
2009-09-24  0:47               ` Nishanth Menon
2009-09-19 14:03           ` [U-Boot] [PATCH 5/6] DLMALLOC:!X86: add av_ initialization Peter Tyser
2009-09-19 15:37             ` Nishanth Menon [this message]
2009-09-19 17:30               ` Peter Tyser
2009-09-23 20:04               ` Wolfgang Denk
2009-09-24  0:50                 ` Nishanth Menon
2009-09-23 19:55   ` [U-Boot] [PATCH 1/6] OMAP3: Fix SDRC init Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB4FAD6.20002@gmail.com \
    --to=menon.nishanth@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox