From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] AT91 pending patches
Date: Mon, 21 Sep 2009 18:07:58 -0500 [thread overview]
Message-ID: <4AB8074E.1070604@windriver.com> (raw)
In-Reply-To: <4AB7D588.9050305@eukrea.com>
Eric B?nard wrote:
> Hi Tom,
>
> may you please comment on the following patches :
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67400
[U-Boot] [PATCH] Add support for Eukrea CPU9260/CPU9G20 SBC
these boards are built around Atmel's AT91SAM9260/9G20 and have
up to 64MB of NOR flash, up to 128MB of SDRAM, up to 2GB of NAND
and include a 10/100 Ethernet PHY in RMII mode.
This looks like the first revision.
Only comments from Jean.
He liked it so that's an ack .
Some minor ws issues
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/65674
CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR
flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII
mode.
Lots of ws cleanup from v5 to v6.
checkpatch complaining about
checkpatch.pl cpuat91-v6.patch
WARNING: braces {} are not necessary for single statement blocks
#480: FILE: cpu/arm920t/at91rm9200/ks8721.c:222:
+ if (!(value & KS8721_AUTONEG_COMP)) {
+ return 0;
+ }
I will take care of this.
From history, lots of comments
I will do the merge and push these patches this weekend after running
the compiling the configurations. There will be some obvious
conflicts like your maintainer list of boards that I will just handle.
Tom
>
> Many thanks
> Eric
next prev parent reply other threads:[~2009-09-21 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 19:35 [U-Boot] AT91 pending patches Eric Bénard
2009-09-21 23:07 ` Tom [this message]
2009-09-27 23:46 ` Tom
2009-10-09 9:28 ` [U-Boot] [PATCH 1/2] fix cpuat91 compile warning Eric Benard
2009-10-09 9:28 ` [U-Boot] [PATCH 2/2] fix CPU9260/CPU9G20 compile warnings Eric Benard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB8074E.1070604@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox