From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ZOOM2 mux setup
Date: Tue, 22 Sep 2009 18:14:05 -0500 [thread overview]
Message-ID: <4AB95A3D.1050909@windriver.com> (raw)
In-Reply-To: <20090922231334.GA16353@lixom.net>
Olof Johansson wrote:
> Hi,
>
> I stumbled across this when fixing the whitespace in the mux setup tables
> for various omap platforms.
>
> I don't find it to be a very sustainable way of adding random delays into
> the gpio setups. Having it open-coded in a C file is much preferred.
>
> from boards/logicpd/zoom2/zoom2.h:
>
> /* Toggle Reset pin of TL16CP754C device */\
> MUX_VAL(CP(MCBSP4_CLKX), (IEN | PTU | EN | M4)) /* GPIO_152 */\
> udelay(10);\
> MUX_VAL(CP(MCBSP4_CLKX), (IEN | PTD | EN | M4)) /* GPIO_152 */\
>
> Also, it seems like alot of the tables are really pretty common between
> boards. Maybe those should be extracted out to a separate base table,
> with additional per-board tables to be applied on top?
>
GPIO toggling should really be done with gpio interface and not the mux
interface.
I will see about cleaning this up when I have time.
Tom
>
> -Olof
prev parent reply other threads:[~2009-09-22 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 23:13 [U-Boot] ZOOM2 mux setup Olof Johansson
2009-09-22 23:14 ` Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB95A3D.1050909@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox