From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Tue, 22 Sep 2009 18:14:05 -0500
Subject: [U-Boot] ZOOM2 mux setup
In-Reply-To: <20090922231334.GA16353@lixom.net>
References: <20090922231334.GA16353@lixom.net>
Message-ID: <4AB95A3D.1050909@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Olof Johansson wrote:
> Hi,
> 
> I stumbled across this when fixing the whitespace in the mux setup tables
> for various omap platforms.
> 
> I don't find it to be a very sustainable way of adding random delays into
> the gpio setups. Having it open-coded in a C file is much preferred.
> 
> from boards/logicpd/zoom2/zoom2.h:
> 
> /* Toggle Reset pin of TL16CP754C device */\
>         MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTU | EN  | M4)) /* GPIO_152 */\
>  udelay(10);\
>         MUX_VAL(CP(MCBSP4_CLKX),        (IEN  | PTD | EN  | M4)) /* GPIO_152 */\
> 
> Also, it seems like alot of the tables are really pretty common between
> boards. Maybe those should be extracted out to a separate base table,
> with additional per-board tables to be applied on top?
> 

GPIO toggling should really be done with gpio interface and not the mux
interface.

I will see about cleaning this up when I have time.

Tom

> 
> -Olof