From: Heiko Schocher <heiko.schocher@invitel.hu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] fsl_i2c: Wait for STOP condition to propagate
Date: Wed, 23 Sep 2009 11:02:09 +0200 [thread overview]
Message-ID: <4AB9E411.8010601@invitel.hu> (raw)
In-Reply-To: <OF63466F4F.DA680929-ONC125763A.002B879F-C125763A.002BD955@transmode.se>
Hello Joakim,
Joakim Tjernlund wrote:
>> Dear Joakim Tjernlund,
>>
>> In message <1253178437-32398-1-git-send-email-Joakim.Tjernlund@transmode.se> you wrote:
>>> After issuing a STOP one must wait until the STOP has completed
>>> on the bus before doing something new to the controller.
>>>
>>> Also add an extra read of SR as the manual mentions doing that
>>> is a good idea.
>>>
>>> Remove surplus write of CR just before a write, isn't required and
>>> could potentially disturb the I2C bus.
>>>
>>> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>>> ---
>>> drivers/i2c/fsl_i2c.c | 12 ++++++++----
>>> 1 files changed, 8 insertions(+), 4 deletions(-)
>> Could you _please_ start adding some version information to your
>> patches, and a list of changes between the versions?
>>
>> Thanks.
>
> Yes, that was a bit sloppy on my part, sorry. What do you want
> me to do now?
> Resend the whole series or do I get away with it this time?
> All but the last patch is in u-boot-i2c testing(by Heiko) repo already.
You mean with last patch, this patch:?
http://lists.denx.de/pipermail/u-boot/2009-September/061187.html
If, so, I think, I add it also to the u-boot-i2c testing branch,
and it is OK for now, but please for further patches, add some
information as Wolfgang suggested.
thanks
bye
Heiko
next prev parent reply other threads:[~2009-09-23 9:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 9:07 [U-Boot] [PATCH 1/3] fsl_i2c: Wait for STOP condition to propagate Joakim Tjernlund
2009-09-17 9:07 ` [U-Boot] [PATCH 2/3] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_{DFSR/FDR} Joakim Tjernlund
2009-09-17 9:07 ` [U-Boot] [PATCH 3/3] fsl_i2c: Impl. AN2919, rev 5 to calculate FDR/DFSR Joakim Tjernlund
2009-09-17 12:04 ` Heiko Schocher
2009-09-21 10:53 ` Wolfgang Grandegger
2009-09-21 11:34 ` Joakim Tjernlund
2009-09-21 11:59 ` Wolfgang Grandegger
2009-09-21 12:30 ` Joakim Tjernlund
2009-09-17 12:03 ` [U-Boot] [PATCH 2/3] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_{DFSR/FDR} Heiko Schocher
2009-09-17 14:38 ` Timur Tabi
2009-09-17 18:11 ` Joakim Tjernlund
2009-09-17 12:03 ` [U-Boot] [PATCH 1/3] fsl_i2c: Wait for STOP condition to propagate Heiko Schocher
2009-09-17 12:37 ` Joakim Tjernlund
2009-09-22 20:57 ` Wolfgang Denk
2009-09-23 7:58 ` Joakim Tjernlund
2009-09-23 9:02 ` Heiko Schocher [this message]
2009-09-23 9:14 ` Joakim Tjernlund
2009-09-23 12:19 ` Heiko Schocher
-- strict thread matches above, loose matches on Subject: below --
2009-09-16 11:31 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB9E411.8010601@invitel.hu \
--to=heiko.schocher@invitel.hu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox