From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4 v3] s5pc1xx: support Samsung s5pc1xx SoC
Date: Wed, 23 Sep 2009 06:46:26 -0500 [thread overview]
Message-ID: <4ABA0A92.8050504@windriver.com> (raw)
In-Reply-To: <1f3430fb0909230342p33272bb1jb2bfe040c9e6dc34@mail.gmail.com>
Minkyu Kang wrote:
> Dear Tom
>
> 2009/9/22 Tom <Tom.Rix@windriver.com>:
>> Minkyu Kang wrote:
>>> This patch adds support for the Samsung s5pc100 and s5pc110
>>> SoCs. The s5pc1xx SoC is an ARM Cortex A8 processor.
>>>
>>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>>> Signed-off-by: HeungJun, Kim <riverful.kim@samsung.com>
>> Ack-ed
>> Tom
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
> Thanks for review
>
> and I have one question
> when I send next patch or commit this patch, should I add Acked-by?
Good question!
From the way you submitted the patch, you added yourself as the
sign off line. When you push the patch, you may add me to the
sign off. As long as the original author gets the credit.
This is also useful so multiple re-reviews of an ack-ed patch
do not stall submission.
Tom
>
> Thanks again
> Minkyu Kang
next prev parent reply other threads:[~2009-09-23 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 7:35 [U-Boot] [PATCH 1/4 v2] s5pc1xx: support Samsung s5pc1xx SoC Minkyu Kang
2009-09-10 10:31 ` Wolfgang Denk
2009-09-11 10:06 ` Minkyu Kang
2009-09-22 12:35 ` [U-Boot] [PATCH 1/4 v3] " Minkyu Kang
2009-09-22 14:34 ` Tom
2009-09-23 10:42 ` Minkyu Kang
2009-09-23 11:46 ` Tom [this message]
2009-10-01 8:20 ` [U-Boot] [PATCH 1/4 v4] " Minkyu Kang
2009-10-09 3:10 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA0A92.8050504@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox