From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 23 Sep 2009 06:58:11 -0500
Subject: [U-Boot] [PATCH 3/4 v3] s5pc1xx: support serial driver
In-Reply-To: <1f3430fb0909230347w6f0f0022o8abcf000cdcd9253@mail.gmail.com>
References: <4AA8AC42.50406@samsung.com>	
	<20090910112630.F265F832E8DE@gemini.denx.de>	
	<1f3430fb0909110343l4ada4eadlf6de0cbed143e5e7@mail.gmail.com>	
	<1f3430fb0909160312m49ed1dfet2b3a0a4371b81874@mail.gmail.com>	
	<4AB8C4B1.4060602@samsung.com> <4AB8DA69.3020808@windriver.com>
	<1f3430fb0909230347w6f0f0022o8abcf000cdcd9253@mail.gmail.com>
Message-ID: <4ABA0D53.9050603@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Minkyu Kang wrote:
> Dear Tom
> 
> 2009/9/22 Tom <Tom.Rix@windriver.com>:
>> Minkyu Kang wrote:
>>> This patch includes the serial driver for s5pc1xx
>>>
>>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> Nak.
>>
>> This looks like the zoom2 serial driver.
>> In the case of zoom2, special handling is needed because the
>> serial is supplied by a detachable debug board and a
>> runtime check was needed.
>>
>> You are not doing a runtime check so why can you not just use
>> one of the generic interfaces ?
>>
>> Tom
> 
> Sorry, I don't understand your pointing.
> I referenced s3c24x0 serial driver,
> 
> please explain more detail.

It is unclear from your commit log why you can not just use
the generic drivers/serial/ns16550.c.

Looking closer at the patch I see that you return
from getc if a modem is being used.

Assuming that the commit log will be fixed, I will review the
patch again.

Tom