public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4 v3] s5pc1xx: add support SMDKC100 board
Date: Wed, 23 Sep 2009 07:05:38 -0500	[thread overview]
Message-ID: <4ABA0F12.7030608@windriver.com> (raw)
In-Reply-To: <1f3430fb0909230359n5fbc84d8i10d67bceaadd506a@mail.gmail.com>

Minkyu Kang wrote:
> Dear Tom
> 
> 2009/9/23 Tom <Tom.Rix@windriver.com>:
>> Minkyu Kang wrote:
>>> Adds new board SMDKC100 that uses s5pc100 SoC
>>>
>>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>>> Signed-off-by: HeungJun, Kim <riverful.kim@samsung.com>
>>> ---

<snip>

>>> +#ifndef CONFIG_ONENAND_IPL
>>> +     /* setting SRAM */
>>> +     ldr     r0, =S5PC100_SROMC_BASE
>>> +     ldr     r1, =0x9
>>> +     str     r1, [r0]
>>> +#endif
>> Where is CONFIG_ONENAND_IPL defined ?
>> If it is not being used, the #ifndef logic should be reduced.
> 
> Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx.
> but not yet applied onenand_ipl patch for s5pc1xx.
> When that patch is applied, we need these logic.
> If necessary, I'll delete these logic until apply the patch.
> 

If the patch already exits, it would be better if it was in this
patchset.  Can we get the onenand_ipl patch ?

Tom

  reply	other threads:[~2009-09-23 12:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10  7:35 [U-Boot] [PATCH 4/4 v2] s5pc1xx: add support SMDKC100 board Minkyu Kang
2009-09-10 11:36 ` Wolfgang Denk
2009-09-11 10:33   ` Minkyu Kang
2009-09-22 12:36     ` [U-Boot] [PATCH 4/4 v3] " Minkyu Kang
2009-09-22 15:03       ` Tom
2009-09-22 15:20         ` Peter Tyser
2009-09-22 16:13           ` Tom
2009-09-22 16:58             ` Peter Tyser
2009-09-23 10:59         ` Minkyu Kang
2009-09-23 12:05           ` Tom [this message]
2009-09-23 14:19             ` Minkyu Kang
2009-09-23 23:43             ` Kyungmin Park
2009-09-24  1:24               ` Tom
2009-10-01  8:20                 ` [U-Boot] [PATCH 4/4 v4] " Minkyu Kang
2009-10-09  3:10                   ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABA0F12.7030608@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox