From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash
Date: Wed, 23 Sep 2009 16:15:22 -0400 [thread overview]
Message-ID: <4ABA81DA.8020007@windriver.com> (raw)
In-Reply-To: <20090923200848.77028832E864@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Kumar Gala,
>
> In message <47177DAB-3638-4978-BD72-78629ADCD9EA@kernel.crashing.org> you wrote:
>> On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote:
> ...
>> applied to 85xx.
>
> Argh... So how much time do you allow for code reviews?
>
> I ask you to wait at least 3...5 working days, please.
>
>
> Please undo, this needs fixing.
I'd considered the line length, but there were many lines in tlb.c
that were already way past 80 char (see directly under the
comment /* TLB 0 - for temp stack in cache */ ) so I
decided to be consistent with existing code.
If you prefer, I can create an add-on patch that re-wraps both
the old/existing code, and the updated line(s).
Let me know what you would prefer.
Paul.
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2009-09-23 20:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 23:08 [U-Boot] [PATCH 0/8] Update/enhance sbc8548 support Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 1/8] sbc8548: delete unused MPC8548CDS info carried over from port Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 2/8] sbc8548: get_clock_freq is not valid for this board Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 4/8] sbc8548: correct local bus SDRAM size from 64M to 128M Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 6/8] sbc8548: enable use of PCI network cards Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 7/8] sbc8548: allow enabling PCI via a make config option Paul Gortmaker
2009-09-18 23:08 ` [U-Boot] [PATCH 8/8] sbc8548: replace README with completely new document Paul Gortmaker
2009-09-19 17:11 ` Kumar Gala
2009-09-19 16:50 ` [U-Boot] [PATCH 7/8] sbc8548: allow enabling PCI via a make config option Kumar Gala
2009-09-19 17:11 ` [U-Boot] [PATCH 6/8] sbc8548: enable use of PCI network cards Kumar Gala
2009-09-23 20:13 ` [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code Wolfgang Denk
2009-09-23 20:22 ` Paul Gortmaker
2009-09-19 16:55 ` [U-Boot] [PATCH 4/8] sbc8548: correct local bus SDRAM size from 64M to 128M Kumar Gala
2009-09-23 20:10 ` Wolfgang Denk
2009-09-23 20:10 ` Wolfgang Denk
2009-09-19 17:11 ` [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash Kumar Gala
2009-09-23 20:08 ` Wolfgang Denk
2009-09-23 20:15 ` Paul Gortmaker [this message]
2009-09-23 20:48 ` Wolfgang Denk
2009-09-23 22:28 ` Paul Gortmaker
2009-09-23 20:07 ` Wolfgang Denk
2009-09-19 17:11 ` [U-Boot] [PATCH 2/8] sbc8548: get_clock_freq is not valid for this board Kumar Gala
2009-09-19 4:25 ` [U-Boot] [PATCH 1/8] sbc8548: delete unused MPC8548CDS info carried over from port Kumar Gala
2009-09-19 16:05 ` Paul Gortmaker
2009-09-19 16:34 ` Kumar Gala
2009-09-19 17:11 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA81DA.8020007@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox