From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Date: Wed, 23 Sep 2009 16:15:22 -0400 Subject: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash In-Reply-To: <20090923200848.77028832E864@gemini.denx.de> References: <1253315326-16961-1-git-send-email-paul.gortmaker@windriver.com> <918ca661b391ce156f39e6c8a086ea93d845caea.1253315004.git.paul.gortmaker@windriver.com> <47177DAB-3638-4978-BD72-78629ADCD9EA@kernel.crashing.org> <20090923200848.77028832E864@gemini.denx.de> Message-ID: <4ABA81DA.8020007@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <47177DAB-3638-4978-BD72-78629ADCD9EA@kernel.crashing.org> you wrote: >> On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote: > ... >> applied to 85xx. > > Argh... So how much time do you allow for code reviews? > > I ask you to wait at least 3...5 working days, please. > > > Please undo, this needs fixing. I'd considered the line length, but there were many lines in tlb.c that were already way past 80 char (see directly under the comment /* TLB 0 - for temp stack in cache */ ) so I decided to be consistent with existing code. If you prefer, I can create an add-on patch that re-wraps both the old/existing code, and the updated line(s). Let me know what you would prefer. Paul. > > Best regards, > > Wolfgang Denk >