From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Date: Wed, 23 Sep 2009 16:22:23 -0400 Subject: [U-Boot] [PATCH 5/8] sbc8548: update PCI/PCI-e support code In-Reply-To: <20090923201310.41EA1832E864@gemini.denx.de> References: <1253315326-16961-1-git-send-email-paul.gortmaker@windriver.com> <918ca661b391ce156f39e6c8a086ea93d845caea.1253315004.git.paul.gortmaker@windriver.com> <8c4c3a2e238ee8ef67637f499cc3269acbb1bf00.1253315004.git.paul.gortmaker@windriver.com> <7d1e5723fdd2d2e1cf51559f876edf17ae8e7a46.1253315004.git.paul.gortmaker@windriver.com> <20090923201310.41EA1832E864@gemini.denx.de> Message-ID: <4ABA837F.1070107@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Paul Gortmaker, > > In message <7d1e5723fdd2d2e1cf51559f876edf17ae8e7a46.1253315004.git.paul.gortmaker@windriver.com> you wrote: >> The PCI/PCI-e support for the sbc8548 was based on an earlier >> version of what the MPC8548CDS board was using, and in its >> current state it won't even compile. This re-syncs it to match >> current MPC85xxCDS/MDS PCI-e support. >> >> It borrows from the MPC8568MDS, in that it pulls the PCI-e I/O >> back to 0xe280_0000 (where PCI2 would be on MPC8548CDS), and >> similarly it coalesces the PCI and PCI-e mem into one single TLB. >> >> Both PCI-x and PCI-e have been tested with intel e1000 cards >> under linux (with an accompanying dts change in place) > ... >> diff --git a/board/sbc8548/sbc8548.c b/board/sbc8548/sbc8548.c >> index 1db32ec..0387140 100644 >> --- a/board/sbc8548/sbc8548.c >> +++ b/board/sbc8548/sbc8548.c > ... >> @@ -400,6 +400,7 @@ pci_init_board(void) >> struct pci_controller *hose = &pcie1_hose; >> struct pci_region *r = hose->regions; >> >> + uint io_sel = (gur->pordevsr & MPC85xx_PORDEVSR_IO_SEL) >> 19; > > Please use I/O accessors. Check globally, please. Already done - commit 48539e37c38c4f6ff78aba6134de2ae3cc3b5dab in the 85xx tree does a global sweep of the board file, and commit ac2cb674bd5dd1405ea0413adb71c253481d9a00 (also in 85xx) is an updated version of this commit that uses the I/O accessors, and also the new PCI helper functions that Kumar requested. Thanks, Paul. > > > Best regards, > > Wolfgang Denk >