From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Wed, 23 Sep 2009 16:00:26 -0500 Subject: [U-Boot] [PATCH v2] TI: OMAP3: Overo Tobi ethernet support In-Reply-To: <653E9043-9AF7-477A-9461-57128C227C6C@lixom.net> References: <20090911204750.GA22246@lixom.net> <20090923145556.GA28659@lixom.net> <4ABA6B78.4010005@windriver.com> <1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net> <20090923191655.D6BC1832E864@gemini.denx.de> <653E9043-9AF7-477A-9461-57128C227C6C@lixom.net> Message-ID: <4ABA8C6A.5000608@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Olof Johansson wrote: > Hi, > > On Sep 23, 2009, at 2:16 PM, Wolfgang Denk wrote: > >> Dear Olof Johansson, >> >> In message <1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net> you wrote: >> ... >>>> Use the omap gpio interface described in README.omap3 >>> >>> Seriously, this code is a 1:1 replica from the evm code. Obviously >>> that code was good enough to merge. >> >> Isn't this godd? It means that we learn from previous mistakes, and >> strive not to repeat them. > > It's also a bit of "we're holding new contributors to higher standards > than we hold ourselves", alternatively "we can merge crap, and when > others use it as examples we'll make them clean it all up". > > So, some of this is OK, I agree. That's why I did the whitespace cleanup > yesterday. But I've reached my limit in this case. > > Bottom line: I don't have more time to sink into this fairly trivial > patch, I don't need to get it merged. I'll just carry it myself out of > tree until I get bored enough to revisit it. > Ugh. Sorry. I was just pointing out that there is a new gpio interface. I did not clean up all the omap3's when the interface was created and I do not expect you to do the same. The problem is making big changes you can not test. I will make the gpio change as a followup after this is merged if you can test it for me. I do not have any other issues. This ok ? Tom > > -Olof