From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Thu, 24 Sep 2009 04:05:56 +0300 Subject: [U-Boot] [PATCH v2] TI: OMAP3: Overo Tobi ethernet support In-Reply-To: <08E4C625-E33D-4E14-97F3-335CE39B24AC@lixom.net> References: <20090911204750.GA22246@lixom.net> <20090923145556.GA28659@lixom.net> <4ABA6B78.4010005@windriver.com> <1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net> <4ABABE9F.2020304@gmail.com> <08E4C625-E33D-4E14-97F3-335CE39B24AC@lixom.net> Message-ID: <4ABAC5F4.3050809@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Olof Johansson said the following on 09/24/2009 03:38 AM: > On Sep 23, 2009, at 7:34 PM, Nishanth Menon wrote: > >> Olof Johansson said the following on 09/23/2009 09:43 PM: >>> On Sep 23, 2009, at 1:39 PM, Tom wrote: >>> >>> >>>> Olof Johansson wrote: >>>> >>>>> diff --git a/board/overo/overo.c b/board/overo/overo.c >>>>> index dd6d286..7d87e52 100644 >>>>> --- a/board/overo/overo.c >>>>> +++ b/board/overo/overo.c >>>>> >>>>> + writel(GPIO0, &gpio3_base->cleardataout); >>>>> + udelay(1); >>>>> + writel(GPIO0, &gpio3_base->setdataout); >>>>> >>>> Use the omap gpio interface described in README.omap3 >>>> >>>> >>> >>> Seriously, this code is a 1:1 replica from the evm code. Obviously >>> that code was good enough to merge. >>> >> >> should'nt we be fixing evm code instead of moving similar code in for >> another platform? > > Sure, but you forgot to attach the patch. > Silly me.. sorry about that.. as you pointed out, I did indeed forget.. need to catch my flight now, and as i dont own an evm, here is the patch in attachment if someone would care to try it out.. Regards, Nishanth Menon -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001--RFC-OMAP3-EVM-remove-direct-gpio-hits.patch Type: text/x-diff Size: 0 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20090924/555ff8b1/attachment.patch