From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 23 Sep 2009 20:24:01 -0500
Subject: [U-Boot] [PATCH 4/4 v3] s5pc1xx: add support SMDKC100 board
In-Reply-To: <9c9fda240909231643l7d64c19aieb53ac8adc5af1d7@mail.gmail.com>
References: <4AA8AC52.4010906@samsung.com>	
	<20090910113658.2123E832E8DE@gemini.denx.de>	
	<1f3430fb0909110333n1014d7e9m1cc466909e423042@mail.gmail.com>	
	<4AB8C4BE.6060802@samsung.com> <4AB8E748.7020303@windriver.com>	
	<1f3430fb0909230359n5fbc84d8i10d67bceaadd506a@mail.gmail.com>	
	<4ABA0F12.7030608@windriver.com>
	<9c9fda240909231643l7d64c19aieb53ac8adc5af1d7@mail.gmail.com>
Message-ID: <4ABACA31.7080309@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Kyungmin Park wrote:
> On Wed, Sep 23, 2009 at 9:05 PM, Tom <Tom.Rix@windriver.com> wrote:
>> Minkyu Kang wrote:
>>> Dear Tom
>>>
>>> 2009/9/23 Tom <Tom.Rix@windriver.com>:
>>>> Minkyu Kang wrote:
>>>>> Adds new board SMDKC100 that uses s5pc100 SoC
>>>>>
>>>>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>>>>> Signed-off-by: HeungJun, Kim <riverful.kim@samsung.com>
>>>>> ---
>> <snip>
>>
>>>>> +#ifndef CONFIG_ONENAND_IPL
>>>>> +     /* setting SRAM */
>>>>> +     ldr     r0, =S5PC100_SROMC_BASE
>>>>> +     ldr     r1, =0x9
>>>>> +     str     r1, [r0]
>>>>> +#endif
>>>> Where is CONFIG_ONENAND_IPL defined ?
>>>> If it is not being used, the #ifndef logic should be reduced.
>>> Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx.
>>> but not yet applied onenand_ipl patch for s5pc1xx.
>>> When that patch is applied, we need these logic.
>>> If necessary, I'll delete these logic until apply the patch.
>>>
>> If the patch already exits, it would be better if it was in this
>> patchset.  Can we get the onenand_ipl patch ?
> 
> To support the s5pc1xx OneNAND IPL. It needs to refactor the current
> OneNAND IPL.
> 
> Now I refactor the OneNAND IPL code first and then I will send a
> OneNAND IPL codes for s5pc1xx.
> 
> I want to leave current patch as is. Since If we delete the OneNAND
> IPL codes. No one can refer the codes. I mean OneNAND IPL parts
> contains clock and memory configuration. These are helpful to someone
> who use NAND or NOR.
> 

Yes. Leaving this patch as-is is Ok.

Please refactor the old patch and include it as this patch's
dependant in the next revision of s5pc1xx patch set.

Tom


> Thank you,
> Kyungmin Park