From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Sat, 26 Sep 2009 07:20:35 +0200
Subject: [U-Boot] [PATCH] OMAP3: Update Overo and Beagle environment
In-Reply-To: <4ABD2C5F.30102@windriver.com>
References: <1253904594-30105-1-git-send-email-dirk.behme@googlemail.com>
	<4ABD2C5F.30102@windriver.com>
Message-ID: <4ABDA4A3.8080108@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Steve,

Tom wrote:
> Dirk Behme wrote:
>> From: Steve Sakoman <sakoman@gmail.com>
>>
>> Update default environment to support new kernel DSS2 subsystem and
>> simplify rootfs type and location changes.
>>
>> Signed-off-by: Steve Sakoman <sakoman@gmail.com>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>
>> ---
>>  include/configs/omap3_beagle.h |   27 +++++++++++++++++++--------
>>  include/configs/omap3_overo.h  |   27 +++++++++++++++++++--------
>>  2 files changed, 38 insertions(+), 16 deletions(-)
>>
>> Index: u-boot-ti/include/configs/omap3_overo.h
>> ===================================================================
>> --- u-boot-ti.orig/include/configs/omap3_overo.h
>> +++ u-boot-ti/include/configs/omap3_overo.h
>> @@ -155,16 +155,27 @@
>>  #define CONFIG_EXTRA_ENV_SETTINGS \
>>      "loadaddr=0x82000000\0" \
>>      "console=ttyS2,115200n8\0" \
>> -    "videomode=1024x768 at 60,vxres=1024,vyres=768\0" \
>> -    "videospec=omapfb:vram:2M,vram:4M\0" \
>> +    "vram=12M\0" \
>> +    "dvimode=1024x768MR-16 at 60\0" \
>> +    "defaultdisplay=dvi\0" \
>> +    "mmcroot=/dev/mmcblk0p2 rw\0" \
>> +    "mmcrootfstype=ext3 rootwait\0" \
>> +    "nandroot=/dev/mtdblock4 rw\0" \
>> +    "nandrootfstype=jffs2\0" \
>>      "mmcargs=setenv bootargs console=${console} " \
>> -        "video=${videospec},mode:${videomode} " \
>> -        "root=/dev/mmcblk0p2 rw " \
>> -        "rootfstype=ext3 rootwait\0" \
>> +        "vram=${vram} " \
>> +        "omapfb.mode=dvi:${dvimode} " \
>> +        "omapfb.debug=y " \
> 
> Is setting the debug option needed ?
> This would seem useful (from the name) only to developers
> 
>> +        "omapdss.def_disp=${defaultdisplay} " \
>> +        "root=${mmcroot} " \
>> +        "rootfstype=${mmcrootfstype}\0" \
>>      "nandargs=setenv bootargs console=${console} " \
>> -        "video=${videospec},mode:${videomode} " \
>> -        "root=/dev/mtdblock4 rw " \
>> -        "rootfstype=jffs2\0" \
>> +        "vram=${vram} " \
>> +        "omapfb.mode=dvi:${dvimode} " \
>> +        "omapfb.debug=y " \
>> +        "omapdss.def_disp=${defaultdisplay} " \
> 
>  From vram to omapdss.def_disp are common for nand and mmc.
> These should be changed to something like
> 
> "videoargs= .... "
> 
> Similar for beagle.

Any opinion on this and above (omapfb.debug)?

Regards

Dirk