From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 28 Sep 2009 07:46:31 +0200 Subject: [U-Boot] [PATCH 1/1] TI OMAP3 Use arm init sequence to initialize i2c In-Reply-To: <4AC04F59.5000501@googlemail.com> References: <1253810115-27861-1-git-send-email-Tom.Rix@windriver.com> <1253810115-27861-2-git-send-email-Tom.Rix@windriver.com> <4AC0493C.7080302@denx.de> <4AC04F59.5000501@googlemail.com> Message-ID: <4AC04DB7.9050808@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Dirk, Dirk Behme wrote: > Heiko Schocher wrote: >> Hello Tom, >> >> Tom Rix wrote: >>> This changes fixes an early i2c error. >>> >>> It appears that I2C is working because once a read or write >>> error is detected, the omap24xx_i2c driver calls i2c_init >>> inside its error handling check. >>> >>> While it is ok to attempt error handling this way, the boards >>> must not depend on this side effect to initialize it's i2c. >>> >>> Instead of explicitly calling i2c_init for every board, use >>> the generic arm initialization in lib_arm/board.c. By defining >>> the config variable CONFIG_HARD_I2C, the omap3 i2c initialization >>> is included in the init_sequence table. >>> >>> Run tested on Beagle. >>> Compile tested on the omap3's >>> >>> Signed-off-by: Tom Rix >>> --- >> >> Patch does not apply: > > It seems that it applies to u-boot-ti. Is it ok to move it through > u-boot-ti into mainline? This is okay for me, so I just make: Acked-by: Heiko Schocher bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany