[U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

Olof Johansson
2009-09-22T21:36:44Z

On Sep 22, 2009, at 4:34 PM, Wolfgang Denk wrote:

> Dear Olof Johansson,
>
> In message <20090922203431.GA14113@lixom.net> you wrote:
>>
>>>> + MUX_VAL(CP(GPMC_CLK), (IDIS | PTU | EN | M0)) /*GPMC_CLK*/\
>>>> + MUX_VAL(CP(GPMC_WAIT2), (IEN | PTU | EN | M4)) /*GPIO_64*/\
>>>> + /* - SMSC911X_NRES*/\
>>>> + MUX_VAL(CP(MCSPI1_CS2), (IEN | PTU | DIS | M4)) /*GPIO_176 */\
>>>> + /* - LAN_INTR */\
>>>
>>> Please use either no indentatioin at all, or indent by a multiple of
>>> TAB characters.
>>
>> So no aligning with spaces at the end of a run of tabs to make them
>> line
>> up? Ok, if you prefer so.
>
> I was referring to the initial blank at the very beginning of the
> line.

Ah, crap. Thanks.

>
>>> Please do not use an C++ comments, and do not add dead code.
>>
>> What is the preferred way to show that the option is available but
>> not enabled
>> by default?
>
> Use a C comment, if you must.
>
>> This patch has been applied and pulled though. I'll submit an
>> incremental patch to address the above.
>
> No, please submit a new version which also incorporates the cleanup
> patches by Dirk.

I didn't see those, since I wasn't cc:d.

> I will not pull the current version.

So much for delegating maintainership. :)

-Olof