[U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

Olof Johansson
2009-09-22T20:34:31Z

On Tue, Sep 22, 2009 at 09:41:42PM +0200, Wolfgang Denk wrote:

> Please use "git format-patch" / "git send-email" to create and submit
> patches. For example, it is always nice to see a file statistics in
> the patch.

k.

> > + MUX_VAL(CP(GPMC_CLK), (IDIS | PTU | EN | M0)) /*GPMC_CLK*/\
> > + MUX_VAL(CP(GPMC_WAIT2), (IEN | PTU | EN | M4)) /*GPIO_64*/\
> > + /* - SMSC911X_NRES*/\
> > + MUX_VAL(CP(MCSPI1_CS2), (IEN | PTU | DIS | M4)) /*GPIO_176 */\
> > + /* - LAN_INTR */\
>
> Please use either no indentatioin at all, or indent by a multiple of
> TAB characters.

So no aligning with spaces at the end of a run of tabs to make them line
up? Ok, if you prefer so.

> > diff --git a/include/configs/omap3_overo.h b/include/configs/omap3_overo.h
> > index 07a031b..6616b55 100644
> > --- a/include/configs/omap3_overo.h
> > +++ b/include/configs/omap3_overo.h
> > @@ -28,7 +28,8 @@
> > #define CONFIG_OMAP 1 /* in a TI OMAP core */
> > #define CONFIG_OMAP34XX 1 /* which is a 34XX */
> > #define CONFIG_OMAP3430 1 /* which is in a 3430 */
> > -#define CONFIG_OMAP3_OVERO 1 /* working with overo */
> > +#define CONFIG_OMAP3_OVERO 1 /* working with overo */
> > +//#define CONFIG_OMAP3_OVERO_TOBI 1 /* overo mounted on tobi */
>
> Please do not use an C++ comments, and do not add dead code.

What is the preferred way to show that the option is available but not enabled
by default?

> > +#if !defined(CONFIG_OMAP3_OVERO_TOBI)
> > +#undef CONFIG_CMD_NET /* bootp, tftpboot, rarpboot */
> > +#endif
> > +
> > +
>
> Only one blank line, please.
>
> > +#endif /* (CONFIG_CMD_NET) */
> > +
> > +
>
> Ditto.

Sure (on both).

This patch has been applied and pulled though. I'll submit an incremental patch to address the above.

-Olof