[U-Boot] [PATCH v2] TI: OMAP3: Overo Tobi ethernet support

Olof Johansson
2009-09-24T00:38:29Z

On Sep 23, 2009, at 7:34 PM, Nishanth Menon wrote:

> Olof Johansson said the following on 09/23/2009 09:43 PM:
>> On Sep 23, 2009, at 1:39 PM, Tom wrote:
>>
>>
>>> Olof Johansson wrote:
>>>
>>>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>>>> index dd6d286..7d87e52 100644
>>>> --- a/board/overo/overo.c
>>>> +++ b/board/overo/overo.c
>>>>
>>>> + writel(GPIO0, &gpio3_base->cleardataout);
>>>> + udelay(1);
>>>> + writel(GPIO0, &gpio3_base->setdataout);
>>>>
>>> Use the omap gpio interface described in README.omap3
>>>
>>>
>>
>> Seriously, this code is a 1:1 replica from the evm code. Obviously
>> that code was good enough to merge.
>>
>
> should'nt we be fixing evm code instead of moving similar code in for
> another platform?

Sure, but you forgot to attach the patch.

-Olof