[U-Boot] [PATCH v3] TI: OMAP3: Overo Tobi ethernet support

Paulraj, Sandeep
2009-10-10T18:24:13Z

> > I'm a little confused :-)
> > I realized when I was trying to apply this patch that this is already
> part of the u-boot-ti and u-boot-arm trees.
> >
> > I am referring to
> > http://git.denx.de/?p=u-boot/u-boot-
> ti.git;a=commitdiff;h=4eb3af078267e103fb957cb831497cf7670fb3f4
> >
> > The patch in this e-mail chain was supposed to fix a bug discovered
> after Tom updated his tree.
> >
> > Since this patch was already part of u-boot-ti and u-boot-arm trees, I
> don't see how this fixes a bug.
>
> It's easy ;)
>
> The applied patch has a bug that the chip detection is done too late.
> It has to be done some lines earlier:
>
> http://lists.denx.de/pipermail/u-boot/2009-October/062150.html
>
> (which is against the patch already applied).
>
> So there are two options to deal with this:
>
> a) Apply
>
> http://lists.denx.de/pipermail/u-boot/2009-October/062150.html
>
> on top of the patch already in u-boot-ti (and u-boot-arm)
>
> or
>
> b) Revert
>
> http://git.denx.de/?p=u-boot/u-boot-
> ti.git;a=commitdiff;h=4eb3af078267e103fb957cb831497cf7670fb3f4
>
> and apply
>
> http://lists.denx.de/pipermail/u-boot/2009-October/062153.html
>
> instead which has the "make the chip detection earlier" fix from (a)
> above incorporated.
>
> Best regards
>
> Dirk

I have been enlightened :-)

I have pushed this to u-boot-ti next

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=shortlog;h=refs/heads/next

Thanks,
Sandeep