[U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

Wolfgang Denk
2009-09-22T21:34:21Z

Dear Olof Johansson,

In message <20090922203431.GA14113@lixom.net> you wrote:
>
> > > + MUX_VAL(CP(GPMC_CLK), (IDIS | PTU | EN | M0)) /*GPMC_CLK*/\
> > > + MUX_VAL(CP(GPMC_WAIT2), (IEN | PTU | EN | M4)) /*GPIO_64*/\
> > > + /* - SMSC911X_NRES*/\
> > > + MUX_VAL(CP(MCSPI1_CS2), (IEN | PTU | DIS | M4)) /*GPIO_176 */\
> > > + /* - LAN_INTR */\
> >
> > Please use either no indentatioin at all, or indent by a multiple of
> > TAB characters.
>
> So no aligning with spaces at the end of a run of tabs to make them line
> up? Ok, if you prefer so.

I was referring to the initial blank at the very beginning of the
line.

> > Please do not use an C++ comments, and do not add dead code.
>
> What is the preferred way to show that the option is available but not enabled
> by default?

Use a C comment, if you must.

> This patch has been applied and pulled though. I'll submit an incremental patch to address the above.

No, please submit a new version which also incorporates the cleanup
patches by Dirk.

I will not pull the current version.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That's their goal, remember, a goal that's really contrary to that of
the programmer or administrator. We just want to get our jobs done.
$Bill just wants to become $$Bill. These aren't even marginallly
congruent.
-- Tom Christiansen in <6jhtqk$qls$1@csnews.cs.colorado.edu>