public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Felix Radensky <felix@embedded-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling
Date: Tue, 29 Sep 2009 00:17:07 +0200	[thread overview]
Message-ID: <4AC135E3.8040302@embedded-sol.com> (raw)
In-Reply-To: <1254156809-10678-1-git-send-email-sr@denx.de>

Hi, Stefan

Stefan Roese wrote:
> This patch merges the ECC handling (ECC parity byte writing) into one
> file (ecc.c) for all PPC4xx SDRAM controllers except for PPC440EPx/GRx.
> This exception is because only those PPC's use the completely different
> Denali SDRAM controller core.
>
> Previously we had two routines to generate/write the ECC parity bytes.
> With this patch we now only have one core function left.
>
> Tested on Kilauea (no ECC) and Katmai (with and without ECC).
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Felix Radensky <felix@embedded-sol.com>
> Cc: Grant Erickson <gerickson@nuovations.com>
> Cc: Pieter Voorthuijsen <pv@prodrive.nl>
> ---
> Pieter, the p3p440 is currently the only PPC4xx DDR based board (non DDR2)
> with ECC enabled. Could you please test this patch on the p3p440, and
> let me know if you see any problems?
>
> And Felix & Grant, it would be great if you could test this patch on your
> platforms as well.
>
> Thanks.
>
>   

Patch does not apply. I've tried both u-boot.git and u-boot-ppc4xx.git.

Applying ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling
error: patch failed: cpu/ppc4xx/44x_spd_ddr2.c:198
error: cpu/ppc4xx/44x_spd_ddr2.c: patch does not apply
Patch failed at 0001.

After fixing the problem manually I was able to successfully test
your patch on 405EXr and 460EX boards with ECC.

Thanks a lot.

Felix.

  reply	other threads:[~2009-09-28 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28 16:53 [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling Stefan Roese
2009-09-28 22:17 ` Felix Radensky [this message]
2009-09-29  4:36   ` Stefan Roese
2009-09-29  6:24     ` Felix Radensky
2009-09-29  6:35       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC135E3.8040302@embedded-sol.com \
    --to=felix@embedded-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox