From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI: DaVinci DM355: Fix Compilation warning
Date: Tue, 29 Sep 2009 07:24:26 -0500 [thread overview]
Message-ID: <4AC1FC7A.1000700@windriver.com> (raw)
In-Reply-To: <1254187262-7269-1-git-send-email-s-paulraj@ti.com>
s-paulraj at ti.com wrote:
> From: Sandeep Paulraj <s-paulraj@ti.com>
>
> This patch fixes a compilation warning while building DM355
>
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
> ---
> board/davinci/dm355evm/dm355evm.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/board/davinci/dm355evm/dm355evm.c b/board/davinci/dm355evm/dm355evm.c
> index 0a44748..5dd3b0d 100644
> --- a/board/davinci/dm355evm/dm355evm.c
> +++ b/board/davinci/dm355evm/dm355evm.c
> @@ -96,11 +96,11 @@ static void nand_dm355evm_select_chip(struct mtd_info *mtd, int chip)
> u32 rbase = (u32) this->IO_ADDR_R;
>
> if (chip == 1) {
> - __set_bit(14, &wbase);
> - __set_bit(14, &rbase);
> + __set_bit(14, (void *)&wbase);
> + __set_bit(14, (void *)&rbase);
> } else {
> - __clear_bit(14, &wbase);
> - __clear_bit(14, &rbase);
> + __clear_bit(14, (void *)&wbase);
> + __clear_bit(14, (void *)&rbase);
> }
> this->IO_ADDR_W = (void *)wbase;
> this->IO_ADDR_R = (void *)rbase;
It looks like __clear_bit is #defined to generic_clear_bit which has
this declaration. generic_clear_bit(int nr, volatile unsigned long addr)
So maybe changing u32 to volatile unsigned long will work?
Also it looks like dm365evm has the same logic for chip select.
At the least, it should also be fixed. Since they look like copies, it
would be better if there was a common function.
Tom
prev parent reply other threads:[~2009-09-29 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 1:21 [U-Boot] [PATCH] TI: DaVinci DM355: Fix Compilation warning s-paulraj at ti.com
2009-09-29 12:24 ` Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC1FC7A.1000700@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox