From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 30 Sep 2009 16:48:33 -0500
Subject: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D92EC0C2F@dlee01.ent.ti.com>
References: <1254187792-7441-1-git-send-email-s-paulraj@ti.com>
	<4AC1FE5C.4070503@windriver.com>
	<20090930203512.9598D832E408@gemini.denx.de>
	<4AC3C5E0.5070904@windriver.com>
	<0554BEF07D437848AF01B9C9B5F0BC5D92EC0C2F@dlee01.ent.ti.com>
Message-ID: <4AC3D231.1090205@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Paulraj, Sandeep wrote:
>> Wolfgang Denk wrote:
>>> Dear Tom,
>>>
>>> In message <4AC1FE5C.4070503@windriver.com> you wrote:
>>>>> +struct davinci_gpio {
>>>>> +	unsigned int	dir;
>>>>> +	unsigned int	out_data;
>>>>> +	unsigned int	set_data;
>>>>> +	unsigned int	clr_data;
>>>>> +	unsigned int	in_data;
>>>>> +	unsigned int	set_rising;
>>>>> +	unsigned int	clr_rising;
>>>>> +	unsigned int	set_falling;
>>>>> +	unsigned int	clr_falling;
>>>>> +	unsigned int	intstat;
>>>>> +};
>>>> Convert the tabs to spaces in the in the whitespace between
>>>> type and elemement names
>>>> unsigned int	dir; -> unsigned int dir;
>>>> For all of the elements
>>> Why? It is not really important here, but especially when mixing data
>>> types, TABs are preferred, as they will allow for nice vertical
>>> alignment.
>>>
>> OK. TABs are preferred.
>>
>> The structure defined below it used a single space.
>> When looked at together, it seemed to me to be inconsistent.
>>
>> Tom
> What do about this patch. You ACK'ed it
> Do you want me to revert to the original patch ?

I will defer to Wolfgang on this.
Since I caused the problem, I will fix it.
Tom

> 
>>> Best regards,
>>>
>>> Wolfgang Denk
>>>
>