public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mem_mtest: bail out after finding 1st memory error.
Date: Thu, 01 Oct 2009 10:00:50 -0400	[thread overview]
Message-ID: <4AC4B612.7020306@windriver.com> (raw)
In-Reply-To: <20090930214628.A8B8F832E408@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Paul Gortmaker,
> 
> In message <4AC3C540.9050004@windriver.com> you wrote:
>> If you still think it is best to maintain current behaviour
>> and not stop after the 1st error, that is fine, I can do that,
>> but I just wanted to be sure it was clear why I did it this
>> way.
> 
> I have used the code many times (well, to be honest, not sooo many
> times, but several times) exactly that way: letting it run forever
> (or, for a long time), while manipulating the hardware (like using a
> hair dryer resp. cooling spray on it). In such a situation it is very
> useful when the code does _not_ terminate after the first error (even
> is this might have been the intention in earlier versions).

Definitely a valid use case.  Hopefully one I never have to use
personally, mind you.

> 
> So beause (1) it is the behaviour users might be used to, (2) I see
> use cases for this and (3) adding a new option will allow to have both
> beheaviours so anybody can chose what he wants, I think we should do
> as I suggested.

OK.  I can do that.  What about the CONFIG_ALT_MEMTEST then?
Should it be changed to run continuously as well, so at least
the two tests are consistent in their default behaviours?

Paul.

> 
> Best regards,
> 
> Wolfgang Denk
> 

  reply	other threads:[~2009-10-01 14:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 19:21 [U-Boot] [PATCH] mem_mtest: bail out after finding 1st memory error Paul Gortmaker
2009-09-30 20:23 ` Wolfgang Denk
2009-09-30 20:53   ` Paul Gortmaker
2009-09-30 21:46     ` Wolfgang Denk
2009-10-01 14:00       ` Paul Gortmaker [this message]
2009-10-01 18:33         ` Wolfgang Denk
2009-10-01 23:52           ` [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C Paul Gortmaker
2009-10-01 23:57             ` Mike Frysinger
2009-10-02  0:04               ` Paul Gortmaker
2009-10-02 22:18                 ` Paul Gortmaker
2009-10-03  6:19                   ` Mike Frysinger
2009-10-18 20:57                   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC4B612.7020306@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox