From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 01 Oct 2009 20:04:27 -0400
Subject: [U-Boot] [PATCH] mem_mtest: fix error reporting,
 allow escape with ^C
In-Reply-To: <200910011957.51226.vapier@gentoo.org>
References: <20091001183335.6D502832E408@gemini.denx.de>
	<1254441147-28751-1-git-send-email-paul.gortmaker@windriver.com>
	<200910011957.51226.vapier@gentoo.org>
Message-ID: <4AC5438B.903@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
> On Thursday 01 October 2009 19:52:27 Paul Gortmaker wrote:
>>  		if (iteration_limit && iterations > iteration_limit) {
>> -			printf("Tested %d iteration(s) without errors.\n",
>> -				iterations-1);
>> +			printf("Tested %d iteration(s) with %lu errors.\n",
>> +				iterations-1, errs);
>>  			return 0;
> 
> if you're showing the errs variable, then presumably it could possibly be non-
> zero, so you wouldnt want to return 0 right ?
> 	return !!errs;
> 
>>  char *argv[]) incr = -incr;
>>  	}
>>  #endif
>> -	return rcode;
>> +	return 0;
> 
> i dont think you want to return 0 all the time here right ?
> 	return !!errs;

Doh! I had it in my mind to "return errs!=0;" and then forgot.

Thanks, I'll respin and resend tomorrow.
Paul.

> 
> otherwise, the basic ^C handling is something that has annoyed me in the past, 
> so acked-by for that :)
> -mike