From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] Update all board to support new bbmiiphy driver (with multibus support)
Date: Sat, 10 Oct 2009 00:02:59 -0700 [thread overview]
Message-ID: <4AD031A3.8050701@gmail.com> (raw)
In-Reply-To: <1254836704-24209-4-git-send-email-luigi.mantellini@idf-hit.com>
Luigi,
Luigi 'Comio' Mantellini wrote:
> Signed-off-by: Luigi 'Comio' Mantellini <luigi.mantellini@idf-hit.com>
> ---
> include/configs/ISPAN.h | 4 ++++
> include/configs/MPC8260ADS.h | 3 +++
> include/configs/MPC8266ADS.h | 4 ++++
> include/configs/MPC8560ADS.h | 4 ++++
> include/configs/Rattler.h | 4 ++++
> include/configs/SBC8540.h | 4 ++++
> include/configs/TQM8272.h | 3 +++
> include/configs/VoVPN-GW.h | 4 ++++
> include/configs/ZPC1900.h | 4 ++++
> include/configs/ep8248.h | 4 ++++
> include/configs/ep82xxm.h | 4 ++++
> include/configs/gw8260.h | 4 ++++
> include/configs/hymod.h | 12 ++++++++++++
> include/configs/muas3001.h | 4 ++++
> include/configs/ppmc8260.h | 4 ++++
> include/configs/sacsng.h | 4 ++++
> include/configs/sbc8260.h | 4 ++++
> include/configs/sbc8560.h | 4 ++++
> 18 files changed, 78 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/ISPAN.h b/include/configs/ISPAN.h
> index 6eb466a..02a188d 100644
> --- a/include/configs/ISPAN.h
> +++ b/include/configs/ISPAN.h
> @@ -84,6 +84,10 @@
> * GPIO pins used for bit-banged MII communications
> */
> #define MDIO_PORT 3 /* Port D */
> +#define MDIO_DECLARE volatile ioport_t *iop = \
> + ioport_addr ((immap_t *) CONFIG_SYS_IMMR, MDIO_PORT)
>
This, and all the others, are longer than 80 characters. Please remove
3 tabs from each and they'll fit
> +#define MDC_DECLARE MDIO_DECLARE
>
Please remove a tab so this aligns with MDIO_DECLARE. Apply globally.
<snip>
regards,
Ben
next prev parent reply other threads:[~2009-10-10 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 13:45 [U-Boot] [PATCH 0/3 v4] New MIIPHYBB implementation with multi-bus support Luigi 'Comio' Mantellini
2009-10-06 13:45 ` [U-Boot] [PATCH 1/3 v4] New Bit-banged MII driver (MIIPHYBB) " Luigi 'Comio' Mantellini
2009-10-06 13:45 ` [U-Boot] [PATCH 2/3] Add bb_miiphy_init call before any ethernet bring-up code Luigi 'Comio' Mantellini
2009-10-06 13:45 ` [U-Boot] [PATCH 3/3] Update all board to support new bbmiiphy driver (with multibus support) Luigi 'Comio' Mantellini
2009-10-10 7:02 ` Ben Warren [this message]
2009-10-10 7:00 ` [U-Boot] [PATCH 0/3 v4] New MIIPHYBB implementation with multi-bus support Ben Warren
-- strict thread matches above, loose matches on Subject: below --
2009-09-22 13:11 [U-Boot] [PATCH 0/3] " Luigi 'Comio' Mantellini
2009-09-22 13:11 ` [U-Boot] [PATCH 1/3] Bit-banged MII driver " Luigi 'Comio' Mantellini
2009-09-22 13:11 ` [U-Boot] [PATCH 2/3] Add bb_miiphy_init call before any ethernet bring-up code Luigi 'Comio' Mantellini
2009-09-22 13:11 ` [U-Boot] [PATCH 3/3] Update all board to support new bbmiiphy driver (with multibus support) Luigi 'Comio' Mantellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD031A3.8050701@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox