[U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const

Nishanth Menon
2009-10-11T15:01:08Z

Paulraj, Sandeep said the following on 10/11/2009 09:48 AM:
>
>> Dirk Behme said the following on 10/11/2009 02:54 AM:
>>
>>> Nishanth Menon wrote:
>>>
>>>
>>>> gpmc_config should not be a variant as it is board specific
>>>> hence make it a const parameter
>>>>
>>>>
>>> Having this in u-boot-ti/next results in
>>>
>>> - All non-SDP3430 boards have
>>>
>>> mem.c: In function 'gpmc_init':
>>> mem.c:250: warning: assignment discards qualifiers from pointer target
>>> type
>>>
>>> - Zoom2 fails to build with
>>>
>>> zoom2.c:54: error: conflicting types for 'enable_gpmc_cs_config'
>>> /include/asm/arch/sys_proto.h:38: error: previous declaration of
>>> 'enable_gpmc_cs_config' was here
>>>
>>> Reverting this patch makes both go away
>>>
>> Redone patch attached - MAKEALL tested ONLY. apologies on the noise.
>>
>
> Pushed to u-boot-ti next
>
> http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commit;h=78c38ce87f7423eedba844e8594cfc5a4fa6051b
>
>
thanks. i have an ethernet patch.. but i need to reach office later
today to test it..
Regards,
Nishanth Menon