[U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const

Paulraj, Sandeep
2009-10-11T12:22:06Z

>
> Nishanth Menon wrote:
> > gpmc_config should not be a variant as it is board specific
> > hence make it a const parameter
>
> Having this in u-boot-ti/next results in
>
> - All non-SDP3430 boards have
>
> mem.c: In function 'gpmc_init':
> mem.c:250: warning: assignment discards qualifiers from pointer target
> type
>
> - Zoom2 fails to build with
>
> zoom2.c:54: error: conflicting types for 'enable_gpmc_cs_config'
> /include/asm/arch/sys_proto.h:38: error: previous declaration of
> 'enable_gpmc_cs_config' was here
>
> Reverting this patch makes both go away.
>
> Then we get
>
> sdp.c: In function 'board_init':
> sdp.c:109: warning: passing argument 1 of 'enable_gpmc_cs_config'
> discards qualifiers from pointer target type
> sdp.c:111: warning: passing argument 1 of 'enable_gpmc_cs_config'
> discards qualifiers from pointer target type
> sdp.c:113: warning: passing argument 1 of 'enable_gpmc_cs_config'
> discards qualifiers from pointer target type
> sdp.c:115: warning: passing argument 1 of 'enable_gpmc_cs_config'
> discards qualifiers from pointer target type
>
> for SDP3430 only, though.
>
> So I'd like to have this patch reverted in u-boot-ti/next and then
>
> a) Fix sdp.c only
>
> or
>
> b) test the other boards, too, before applying this patch.
>
> Best regards
>
> Dirk
>

My bad, should have compiled all other boards as well.

I have reverted.

Thanks,
Sandeep