From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Sun, 11 Oct 2009 09:35:30 -0500 Subject: [U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const In-Reply-To: <4AD18F29.20100@googlemail.com> References: <1254881879-19257-1-git-send-email-nm@ti.com> <1254881879-19257-2-git-send-email-nm@ti.com> <1254881879-19257-3-git-send-email-nm@ti.com> <1254881879-19257-4-git-send-email-nm@ti.com> <4AD18F29.20100@googlemail.com> Message-ID: <4AD1ED32.1040602@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dirk Behme said the following on 10/11/2009 02:54 AM: > Nishanth Menon wrote: > >> gpmc_config should not be a variant as it is board specific >> hence make it a const parameter >> > > Having this in u-boot-ti/next results in > > - All non-SDP3430 boards have > > mem.c: In function 'gpmc_init': > mem.c:250: warning: assignment discards qualifiers from pointer target > type > > - Zoom2 fails to build with > > zoom2.c:54: error: conflicting types for 'enable_gpmc_cs_config' > /include/asm/arch/sys_proto.h:38: error: previous declaration of > 'enable_gpmc_cs_config' was here > > Reverting this patch makes both go away Redone patch attached - MAKEALL tested ONLY. apologies on the noise. ethernet still pending.. Regards, Nishanth Menon -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-OMAP3-make-gpmc_config-as-const.patch Type: text/x-diff Size: 0 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20091011/596310bb/attachment.patch