public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <menon.nishanth@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const
Date: Sun, 11 Oct 2009 10:01:08 -0500	[thread overview]
Message-ID: <4AD1F334.1000600@gmail.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D932688B8@dlee01.ent.ti.com>

Paulraj, Sandeep said the following on 10/11/2009 09:48 AM:
>   
>> Dirk Behme said the following on 10/11/2009 02:54 AM:
>>     
>>> Nishanth Menon wrote:
>>>
>>>       
>>>> gpmc_config should not be a variant as it is board specific
>>>> hence make it a const parameter
>>>>
>>>>         
>>> Having this in u-boot-ti/next results in
>>>
>>> - All non-SDP3430 boards have
>>>
>>> mem.c: In function 'gpmc_init':
>>> mem.c:250: warning: assignment discards qualifiers from pointer target
>>> type
>>>
>>> - Zoom2 fails to build with
>>>
>>> zoom2.c:54: error: conflicting types for 'enable_gpmc_cs_config'
>>> /include/asm/arch/sys_proto.h:38: error: previous declaration of
>>> 'enable_gpmc_cs_config' was here
>>>
>>> Reverting this patch makes both go away
>>>       
>> Redone patch attached - MAKEALL tested ONLY. apologies on the noise.
>>     
>
> Pushed to u-boot-ti next
>
> http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commit;h=78c38ce87f7423eedba844e8594cfc5a4fa6051b
>
>   
thanks. i have an ethernet patch.. but i need to reach office later
today to test it..
Regards,
Nishanth Menon

  reply	other threads:[~2009-10-11 15:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07  2:17 [U-Boot] [PATCH 0/5 v2] ARM:OMAP3:SDP3430 initial support Nishanth Menon
2009-10-07  2:17 ` [U-Boot] [PATCH 1/5 v2] OMAP3: Fix SDRC init Nishanth Menon
2009-10-07  2:17   ` [U-Boot] [PATCH 2/5] OMAP3: export enable_gpmc_cs_config to board files Nishanth Menon
2009-10-07  2:17     ` [U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const Nishanth Menon
2009-10-07  2:17       ` [U-Boot] [PATCH 4/5] OMAP3: fix warnings when NAND/ONENAND is not used Nishanth Menon
2009-10-07  2:17         ` [U-Boot] [PATCH 5/5 v2] ARM:OMAP3:SDP3430: initial support Nishanth Menon
2009-10-10 19:20         ` [U-Boot] [PATCH 4/5] OMAP3: fix warnings when NAND/ONENAND is not used Paulraj, Sandeep
2009-10-10 19:29       ` [U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const Paulraj, Sandeep
2009-10-11  7:54       ` Dirk Behme
2009-10-11 12:22         ` Paulraj, Sandeep
2009-10-11 14:35         ` Nishanth Menon
2009-10-11 14:48           ` Paulraj, Sandeep
2009-10-11 15:01             ` Nishanth Menon [this message]
2009-10-10 19:18     ` [U-Boot] [PATCH 2/5] OMAP3: export enable_gpmc_cs_config to board files Paulraj, Sandeep
2009-10-10 19:24   ` [U-Boot] [PATCH 1/5 v2] OMAP3: Fix SDRC init Paulraj, Sandeep
2009-10-19 14:53   ` Steve Sakoman
2009-10-19 14:55     ` Dirk Behme
2009-10-19 15:06       ` Steve Sakoman
2009-10-20  2:19         ` [U-Boot] OMAP3 DDR Fix patches (was Re: [PATCH 1/5 v2] OMAP3: Fix SDRC init) Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD1F334.1000600@gmail.com \
    --to=menon.nishanth@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox