From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nishanth Menon <menon.nishanth@gmail.com>
Date: Sun, 11 Oct 2009 10:01:08 -0500
Subject: [U-Boot] [PATCH 3/5] OMAP3: make gpmc_config as const
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D932688B8@dlee01.ent.ti.com>
References: <1254881879-19257-1-git-send-email-nm@ti.com>	<1254881879-19257-2-git-send-email-nm@ti.com>	<1254881879-19257-3-git-send-email-nm@ti.com>	<1254881879-19257-4-git-send-email-nm@ti.com>	<4AD18F29.20100@googlemail.com>
	<4AD1ED32.1040602@gmail.com>
	<0554BEF07D437848AF01B9C9B5F0BC5D932688B8@dlee01.ent.ti.com>
Message-ID: <4AD1F334.1000600@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Paulraj, Sandeep said the following on 10/11/2009 09:48 AM:
>   
>> Dirk Behme said the following on 10/11/2009 02:54 AM:
>>     
>>> Nishanth Menon wrote:
>>>
>>>       
>>>> gpmc_config should not be a variant as it is board specific
>>>> hence make it a const parameter
>>>>
>>>>         
>>> Having this in u-boot-ti/next results in
>>>
>>> - All non-SDP3430 boards have
>>>
>>> mem.c: In function 'gpmc_init':
>>> mem.c:250: warning: assignment discards qualifiers from pointer target
>>> type
>>>
>>> - Zoom2 fails to build with
>>>
>>> zoom2.c:54: error: conflicting types for 'enable_gpmc_cs_config'
>>> /include/asm/arch/sys_proto.h:38: error: previous declaration of
>>> 'enable_gpmc_cs_config' was here
>>>
>>> Reverting this patch makes both go away
>>>       
>> Redone patch attached - MAKEALL tested ONLY. apologies on the noise.
>>     
>
> Pushed to u-boot-ti next
>
> http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commit;h=78c38ce87f7423eedba844e8594cfc5a4fa6051b
>
>   
thanks. i have an ethernet patch.. but i need to reach office later
today to test it..
Regards,
Nishanth Menon