From: Tom Rix <tom@bumblecow.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] V2 of OMAP3 USB device Support
Date: Sun, 11 Oct 2009 11:52:43 -0500 [thread overview]
Message-ID: <4AD20D5B.2090502@bumblecow.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D932688DB@dlee01.ent.ti.com>
Paulraj, Sandeep wrote:
>>
>> The technical change is better handling of address setting on the
>> usb handshaking setup phase.
>>
>> Other changes from Jean's comments
>>
>> 2/8 USB add macros for debugging usb device setup.
>>
>> static inline function replacing debug macros
>>
>> 3/8 TWL4030 Add usb PHY support
>>
>> add empty lines between variables and statements
>> other empty lines added for readablity
>>
>> 4/8 OMAP3 Add usb device support
>>
>> 80+ char lines reduced
>> Used MUSB_FLAGS_PRINT macro suggestion
>> lowercased function names
>> multi-lined ep0_state_enum
>> Used suggestion on udelay to 1000 * 1000
>> add empty lines between variables and statements
>> inverted check of ep0_urb->device_request.wLength
>> other empty lines added for readablity
>>
>> 5/8 OMAP3 zoom1 Add usbtty configuration
>>
>> This was ack-ed by Jean
>>
>> 6/8 OMAP3 beagle Add usbtty configuration
>>
>> This was ack-ed by Jean
>>
>> 8/8 OMAP3 zoom2 Use usbtty if the debug board
>>
>> cleanup using usbtty_* functions or their stubs without #define's
>
> Tom,
>
> Some of these clearly say that they were Ack-ed by Jean.
>
> Did he not push them?
>
Because there were issues with other patches in the patch-set,
these were not pushed.
> How do we want to proceed with this set of patches?
>
There is some changes that may effect davinci.
You should verify that davici targets behave the same.
I believe someone on beagle.org has verified that at least
the usb console works for beagle. There was an issue with
kermit over usbtty that was reported. I do not consider
this to be a blocking issue. More verification that
the patch works for other poeople would be helpful.
The top usb patch is general and should really be reviewed
as a USB change.
These patches are the basis for my current usb development
to get the cdc gadget support from the usb topic branch into
the mainline.
So if changes are needed, it would be good to find out about
them sooner rather than later when I have more code dependent
on them.
Tom
> Thanks,
> Sandeep
>
>
>
next prev parent reply other threads:[~2009-10-11 16:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 16:37 [U-Boot] V2 of OMAP3 USB device Support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 7/8] USBTTY make some function declarations easier to use Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 8/8] OMAP3 zoom2 Use usbtty if the debug board is not connected Tom Rix
2009-10-12 19:08 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Remy Bohmer
2009-10-14 11:14 ` Tom Rix
2009-10-11 16:25 ` [U-Boot] V2 of OMAP3 USB device Support Paulraj, Sandeep
2009-10-11 16:52 ` Tom Rix [this message]
[not found] <931944283939480137@unknownmsgid>
2009-09-29 18:50 ` Remy Bohmer
2009-09-29 18:59 ` Tom
-- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:34 y at windriver.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD20D5B.2090502@bumblecow.com \
--to=tom@bumblecow.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox