public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] Zoom2 Fix serial setup
@ 2009-10-05 22:19 Tom Rix
  2009-10-05 22:19 ` [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup Tom Rix
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2009-10-05 22:19 UTC (permalink / raw)
  To: u-boot


This patch is against u-boot-ti/master 

I run tested this on Zoom2.

Tom

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup
  2009-10-05 22:19 [U-Boot] Zoom2 Fix serial setup Tom Rix
@ 2009-10-05 22:19 ` Tom Rix
  2009-10-11 16:23   ` Paulraj, Sandeep
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2009-10-05 22:19 UTC (permalink / raw)
  To: u-boot

The offset to the chip select is incorrect.

The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,

omap3: embedd gpmc_cs into gpmc config struct

introduced a problem with the serial gpmc setup.

This patch reverts the chip select to its previous value.

The symptoms of this problem are that the Zoom2
currently hangs.

This was run tested on Zoom2.

Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
---
 board/logicpd/zoom2/zoom2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/board/logicpd/zoom2/zoom2.c b/board/logicpd/zoom2/zoom2.c
index d9e2ae5..cd8c9fe 100644
--- a/board/logicpd/zoom2/zoom2.c
+++ b/board/logicpd/zoom2/zoom2.c
@@ -129,7 +129,7 @@ int board_init (void)
 
 	/* Configure console support on zoom2 */
 	gpmc_config = gpmc_serial_TL16CP754C;
-	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
+	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
 			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
 
 	/* board id for Linux */
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup
  2009-10-05 22:19 ` [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup Tom Rix
@ 2009-10-11 16:23   ` Paulraj, Sandeep
  2009-10-11 16:54     ` Tom Rix
  0 siblings, 1 reply; 5+ messages in thread
From: Paulraj, Sandeep @ 2009-10-11 16:23 UTC (permalink / raw)
  To: u-boot


> The offset to the chip select is incorrect.
> 
> The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,
> 
> omap3: embedd gpmc_cs into gpmc config struct
> 
> introduced a problem with the serial gpmc setup.
> 
> This patch reverts the chip select to its previous value.
> 
> The symptoms of this problem are that the Zoom2
> currently hangs.
> 
> This was run tested on Zoom2.
> 
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
>  board/logicpd/zoom2/zoom2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/board/logicpd/zoom2/zoom2.c b/board/logicpd/zoom2/zoom2.c
> index d9e2ae5..cd8c9fe 100644
> --- a/board/logicpd/zoom2/zoom2.c
> +++ b/board/logicpd/zoom2/zoom2.c
> @@ -129,7 +129,7 @@ int board_init (void)
> 
>  	/* Configure console support on zoom2 */
>  	gpmc_config = gpmc_serial_TL16CP754C;
> -	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
> +	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
>  			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
> 
>  	/* board id for Linux */
> --
> 1.6.0.6


Tom,

I'll push this the moment we resolves some of our OMAP3 issues.

Thanks,
Sandeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup
  2009-10-11 16:23   ` Paulraj, Sandeep
@ 2009-10-11 16:54     ` Tom Rix
  2009-10-12 16:12       ` Paulraj, Sandeep
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2009-10-11 16:54 UTC (permalink / raw)
  To: u-boot

Paulraj, Sandeep wrote:
>> The offset to the chip select is incorrect.
>>
>> The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,
>>
>> omap3: embedd gpmc_cs into gpmc config struct
>>
>> introduced a problem with the serial gpmc setup.
>>
>> This patch reverts the chip select to its previous value.
>>
>> The symptoms of this problem are that the Zoom2
>> currently hangs.
>>
>> This was run tested on Zoom2.
>>
>> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
>> ---
>>  board/logicpd/zoom2/zoom2.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/board/logicpd/zoom2/zoom2.c b/board/logicpd/zoom2/zoom2.c
>> index d9e2ae5..cd8c9fe 100644
>> --- a/board/logicpd/zoom2/zoom2.c
>> +++ b/board/logicpd/zoom2/zoom2.c
>> @@ -129,7 +129,7 @@ int board_init (void)
>>
>>  	/* Configure console support on zoom2 */
>>  	gpmc_config = gpmc_serial_TL16CP754C;
>> -	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
>> +	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
>>  			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
>>
>>  	/* board id for Linux */
>> --
>> 1.6.0.6
> 
> 
> Tom,
> 
> I'll push this the moment we resolves some of our OMAP3 issues.
> 

Thanks!
Tom

> Thanks,
> Sandeep
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup
  2009-10-11 16:54     ` Tom Rix
@ 2009-10-12 16:12       ` Paulraj, Sandeep
  0 siblings, 0 replies; 5+ messages in thread
From: Paulraj, Sandeep @ 2009-10-12 16:12 UTC (permalink / raw)
  To: u-boot

 
> Paulraj, Sandeep wrote:
> >> The offset to the chip select is incorrect.
> >>
> >> The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,
> >>
> >> omap3: embedd gpmc_cs into gpmc config struct
> >>
> >> introduced a problem with the serial gpmc setup.
> >>
> >> This patch reverts the chip select to its previous value.
> >>
> >> The symptoms of this problem are that the Zoom2
> >> currently hangs.
> >>
> >> This was run tested on Zoom2.
> >>
> >> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> >> ---
> >>  board/logicpd/zoom2/zoom2.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/board/logicpd/zoom2/zoom2.c b/board/logicpd/zoom2/zoom2.c
> >> index d9e2ae5..cd8c9fe 100644
> >> --- a/board/logicpd/zoom2/zoom2.c
> >> +++ b/board/logicpd/zoom2/zoom2.c
> >> @@ -129,7 +129,7 @@ int board_init (void)
> >>
> >>  	/* Configure console support on zoom2 */
> >>  	gpmc_config = gpmc_serial_TL16CP754C;
> >> -	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
> >> +	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
> >>  			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
> >>
> >>  	/* board id for Linux */

Pushed to u-boot-ti master

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=277651e76c7af164bca7e721ec6cb4ef0b508225

Once we resolve some of our OMAP3 issues I will push the appropriate patches to u-boot-ti master. Those patches are currently in u-boot-ti next

Thanks,
Sandeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-10-12 16:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-05 22:19 [U-Boot] Zoom2 Fix serial setup Tom Rix
2009-10-05 22:19 ` [U-Boot] [PATCH] Zoom2 Fix serial gpmc setup Tom Rix
2009-10-11 16:23   ` Paulraj, Sandeep
2009-10-11 16:54     ` Tom Rix
2009-10-12 16:12       ` Paulraj, Sandeep

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox