[U-Boot] [PATCH 0/5] add TI da8xx support:

[U-Boot] [PATCH 0/5] add TI da8xx support:

[Thompson, Nick (GE EntSol, Intelligent Platforms)]

Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
does outlook even consider that it's okay to mangle my e-mails??? - Please
excuse the mess.

I can fix them, but I'm not going to send them again until people have
had chance to comment on other aspects of the patch set.

Thanks,
Nick.

[U-Boot] [PATCH 0/5] add TI da8xx support:

[Jerry Van Baren]

Hi Nick,

Thompson, Nick (GE EntSol, Intelligent Platforms) wrote:
> Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
> does outlook even consider that it's okay to mangle my e-mails??? - Please
> excuse the mess.

Contrary to popular opinion, spam did not kill email.  There are plenty 
of technical solutions to spam.

Outlook + PHBs killed email.  There is no technical solution for that 
combination.

----------------------------------------------------------------------------
The Hitchhiker's Guide to the Galaxy, in a moment of reasoned lucidity 
which is almost unique among its current tally of five million, nine 
hundred and seventy-three thousand, five hundred and nine pages, says of 
the Sirius Cybernetics Corporation products that "it is very easy to be 
blinded to the essential uselessness of them by the sense of achievement 
you get from getting them to work at all." In other words, - and this is 
the rock-solid principle on which the whole of the Corporation's 
Galaxywide success is founded - their fundamental design flaws are 
completely hidden by their superficial design flaws.

   -- The Hitchhiker's Guide to the Galaxy / Douglas Adams (1952 - 
2001). 1st American ed. New York : Harmony Books, 1980, c1979
----------------------------------------------------------------------------

Best regards,
gvb

[U-Boot] [PATCH 0/5] add TI da8xx support:

[Paulraj, Sandeep]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Thompson, Nick (GE EntSol, Intelligent Platforms)
> Sent: Friday, October 16, 2009 6:33 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH 0/5] add TI da8xx support:
> 
> Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
> does outlook even consider that it's okay to mangle my e-mails??? - Please
> excuse the mess.
> 
> I can fix them, but I'm not going to send them again until people have
> had chance to comment on other aspects of the patch set.
> 
> Thanks,
> Nick.
First of all thanks for taking the initiative for submitting this patch set.
I have some comments. I will reply with my comments tomorrow.

Thanks,
Sandeep

[U-Boot] [PATCH 0/5] add TI da8xx support:

[Tom]

Thompson, Nick (GE EntSol, Intelligent Platforms) wrote:
> Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
> does outlook even consider that it's okay to mangle my e-mails??? - Please
> excuse the mess.
> 
> I can fix them, but I'm not going to send them again until people have
> had chance to comment on other aspects of the patch set.

It is likely your client is mangling other whitespace.

You need to track down why your email client is mangling line wrapping.
You may want to consider switching clients.
When posting patches I use git send-email + msmtp.

Do not get discouraged by this first review.

We will fight through the whitespace in the first round or two
and then hit the technical parts.  In general, it is good to have
your whitespace taken care before you post.  I recommend looking
at the u-boot coding style. http://www.denx.de/wiki/U-Boot/CodingStyle

I also run patches through the linux kernel's checkpatch.pl script.

For viewing whitespace, i use emacs+blank-mode.

Tom


> 
> Thanks,
> Nick.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot