public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] s5pc1xx: SMDKC100: fix compile warnings
Date: Sun, 18 Oct 2009 08:48:28 -0500	[thread overview]
Message-ID: <4ADB1CAC.8060308@windriver.com> (raw)
In-Reply-To: <4AD686A3.1010003@samsung.com>

Minkyu Kang wrote:
> fix the following compile warnings
> warning: dereferencing type-punned pointer will break strict-aliasing rules
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  drivers/serial/serial_s5pc1xx.c      |    2 +-
>  include/asm-arm/arch-s5pc1xx/clock.h |   88 +++++++++++++++++-----------------
>  include/asm-arm/arch-s5pc1xx/gpio.h  |   12 ++--
>  include/asm-arm/arch-s5pc1xx/pwm.h   |   36 +++++++-------
>  include/asm-arm/arch-s5pc1xx/uart.h  |   18 ++++----
>  include/linux/mtd/samsung_onenand.h  |   70 +++++++++++++-------------
>  6 files changed, 113 insertions(+), 113 deletions(-)
> 
> diff --git a/drivers/serial/serial_s5pc1xx.c b/drivers/serial/serial_s5pc1xx.c
> index 64c1dcc..68c06a9 100644
> --- a/drivers/serial/serial_s5pc1xx.c
> +++ b/drivers/serial/serial_s5pc1xx.c
> @@ -74,7 +74,7 @@ void serial_setbrg_dev(const int dev_index)
>  	val = pclk / baudrate;
>  
>  	writel(val / 16 - 1, &uart->ubrdiv);
> -	writel(udivslot[val % 16], &uart->udivslot);
> +	writew(udivslot[val % 16], &uart->udivslot);
>  }

If you are changing to using writew, the table udivslot should also 
change to match the type of udivslot, unsigned short.

Please submit a follow-on change for this.
Ack-ed.

Tom

      parent reply	other threads:[~2009-10-18 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15  2:19 [U-Boot] [PATCH] s5pc1xx: SMDKC100: fix compile warnings Minkyu Kang
2009-10-15  2:30 ` Minkyu Kang
2009-10-18 13:48 ` Tom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADB1CAC.8060308@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox