From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] add TI da8xx support:
Date: Sun, 18 Oct 2009 10:10:01 -0500 [thread overview]
Message-ID: <4ADB2FC9.1070301@windriver.com> (raw)
In-Reply-To: <610D18D1F0BB204D8AB39BB1C42187E804182D50@LONMLVEM09.e2k.ad.ge.com>
Thompson, Nick (GE EntSol, Intelligent Platforms) wrote:
> Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
> does outlook even consider that it's okay to mangle my e-mails??? - Please
> excuse the mess.
>
> I can fix them, but I'm not going to send them again until people have
> had chance to comment on other aspects of the patch set.
It is likely your client is mangling other whitespace.
You need to track down why your email client is mangling line wrapping.
You may want to consider switching clients.
When posting patches I use git send-email + msmtp.
Do not get discouraged by this first review.
We will fight through the whitespace in the first round or two
and then hit the technical parts. In general, it is good to have
your whitespace taken care before you post. I recommend looking
at the u-boot coding style. http://www.denx.de/wiki/U-Boot/CodingStyle
I also run patches through the linux kernel's checkpatch.pl script.
For viewing whitespace, i use emacs+blank-mode.
Tom
>
> Thanks,
> Nick.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
prev parent reply other threads:[~2009-10-18 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 10:33 [U-Boot] [PATCH 0/5] add TI da8xx support: Thompson, Nick (GE EntSol, Intelligent Platforms)
2009-10-16 11:42 ` Jerry Van Baren
2009-10-16 13:43 ` Paulraj, Sandeep
2009-10-18 15:10 ` Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADB2FC9.1070301@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox