From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
Date: Mon, 19 Oct 2009 11:35:40 +0100 [thread overview]
Message-ID: <4ADC40FC.4090103@mimc.co.uk> (raw)
In-Reply-To: <20091019121050.53e034b2@hcegtvedt.norway.atmel.com>
Hans-Christian Egtvedt wrote:
> On Mon, 19 Oct 2009 10:49:00 +0100
> Mark Jackson <mpfj-list@mimc.co.uk> wrote:
>
>> The portmux peripheral pin selection code used when setting up
>> the MACB1 ethernet port has a small (but critical !!) typo.
>>
>
> It does? Where is this fixed in the patch?
Not sure what you mean ...
>
>> Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
>> ---
>> cpu/at32ap/at32ap700x/portmux.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cpu/at32ap/at32ap700x/portmux.c b/cpu/at32ap/at32ap700x/portmux.c
>> index b1f2c6f..a60288f 100644
>> --- a/cpu/at32ap/at32ap700x/portmux.c
>> +++ b/cpu/at32ap/at32ap700x/portmux.c
>> @@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength)
>> portd_mask |= (1 << 15);/* SPD */
>>
>> /* REVISIT: Some pins are probably pure outputs */
>> - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask,
>> + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,
>
> This replaces portc_mask with portd_mask, which looks indeed correcter.
... and this looks like a simple typo to me !?!
Mark
next prev parent reply other threads:[~2009-10-19 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 9:49 [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask Mark Jackson
2009-10-19 10:10 ` Hans-Christian Egtvedt
2009-10-19 10:35 ` Mark Jackson [this message]
2009-10-19 10:48 ` Hans-Christian Egtvedt
2009-10-19 10:53 ` Mark Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADC40FC.4090103@mimc.co.uk \
--to=mpfj-list@mimc.co.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox