From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Jackson Date: Mon, 19 Oct 2009 11:35:40 +0100 Subject: [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask In-Reply-To: <20091019121050.53e034b2@hcegtvedt.norway.atmel.com> References: <4ADC360C.6000704@mimc.co.uk> <20091019121050.53e034b2@hcegtvedt.norway.atmel.com> Message-ID: <4ADC40FC.4090103@mimc.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hans-Christian Egtvedt wrote: > On Mon, 19 Oct 2009 10:49:00 +0100 > Mark Jackson wrote: > >> The portmux peripheral pin selection code used when setting up >> the MACB1 ethernet port has a small (but critical !!) typo. >> > > It does? Where is this fixed in the patch? Not sure what you mean ... > >> Signed-off-by: Mark Jackson >> --- >> cpu/at32ap/at32ap700x/portmux.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/cpu/at32ap/at32ap700x/portmux.c b/cpu/at32ap/at32ap700x/portmux.c >> index b1f2c6f..a60288f 100644 >> --- a/cpu/at32ap/at32ap700x/portmux.c >> +++ b/cpu/at32ap/at32ap700x/portmux.c >> @@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) >> portd_mask |= (1 << 15);/* SPD */ >> >> /* REVISIT: Some pins are probably pure outputs */ >> - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask, >> + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask, > > This replaces portc_mask with portd_mask, which looks indeed correcter. ... and this looks like a simple typo to me !?! Mark