* [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
@ 2009-10-19 9:49 Mark Jackson
2009-10-19 10:10 ` Hans-Christian Egtvedt
0 siblings, 1 reply; 5+ messages in thread
From: Mark Jackson @ 2009-10-19 9:49 UTC (permalink / raw)
To: u-boot
The portmux peripheral pin selection code used when setting up
the MACB1 ethernet port has a small (but critical !!) typo.
Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
---
cpu/at32ap/at32ap700x/portmux.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/at32ap/at32ap700x/portmux.c b/cpu/at32ap/at32ap700x/portmux.c
index b1f2c6f..a60288f 100644
--- a/cpu/at32ap/at32ap700x/portmux.c
+++ b/cpu/at32ap/at32ap700x/portmux.c
@@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength)
portd_mask |= (1 << 15);/* SPD */
/* REVISIT: Some pins are probably pure outputs */
- portmux_select_peripheral(PORTMUX_PORT_D, portc_mask,
+ portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,
PORTMUX_FUNC_B, PORTMUX_BUSKEEPER);
portmux_select_peripheral(PORTMUX_PORT_C, portc_mask,
PORTMUX_FUNC_B, PORTMUX_BUSKEEPER);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
2009-10-19 9:49 [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask Mark Jackson
@ 2009-10-19 10:10 ` Hans-Christian Egtvedt
2009-10-19 10:35 ` Mark Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Hans-Christian Egtvedt @ 2009-10-19 10:10 UTC (permalink / raw)
To: u-boot
On Mon, 19 Oct 2009 10:49:00 +0100
Mark Jackson <mpfj-list@mimc.co.uk> wrote:
> The portmux peripheral pin selection code used when setting up
> the MACB1 ethernet port has a small (but critical !!) typo.
>
It does? Where is this fixed in the patch?
> Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
> ---
> cpu/at32ap/at32ap700x/portmux.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpu/at32ap/at32ap700x/portmux.c b/cpu/at32ap/at32ap700x/portmux.c
> index b1f2c6f..a60288f 100644
> --- a/cpu/at32ap/at32ap700x/portmux.c
> +++ b/cpu/at32ap/at32ap700x/portmux.c
> @@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength)
> portd_mask |= (1 << 15);/* SPD */
>
> /* REVISIT: Some pins are probably pure outputs */
> - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask,
> + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,
This replaces portc_mask with portd_mask, which looks indeed correcter.
<snipp>
--
Best regards,
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
2009-10-19 10:10 ` Hans-Christian Egtvedt
@ 2009-10-19 10:35 ` Mark Jackson
2009-10-19 10:48 ` Hans-Christian Egtvedt
0 siblings, 1 reply; 5+ messages in thread
From: Mark Jackson @ 2009-10-19 10:35 UTC (permalink / raw)
To: u-boot
Hans-Christian Egtvedt wrote:
> On Mon, 19 Oct 2009 10:49:00 +0100
> Mark Jackson <mpfj-list@mimc.co.uk> wrote:
>
>> The portmux peripheral pin selection code used when setting up
>> the MACB1 ethernet port has a small (but critical !!) typo.
>>
>
> It does? Where is this fixed in the patch?
Not sure what you mean ...
>
>> Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
>> ---
>> cpu/at32ap/at32ap700x/portmux.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cpu/at32ap/at32ap700x/portmux.c b/cpu/at32ap/at32ap700x/portmux.c
>> index b1f2c6f..a60288f 100644
>> --- a/cpu/at32ap/at32ap700x/portmux.c
>> +++ b/cpu/at32ap/at32ap700x/portmux.c
>> @@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength)
>> portd_mask |= (1 << 15);/* SPD */
>>
>> /* REVISIT: Some pins are probably pure outputs */
>> - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask,
>> + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,
>
> This replaces portc_mask with portd_mask, which looks indeed correcter.
... and this looks like a simple typo to me !?!
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
2009-10-19 10:35 ` Mark Jackson
@ 2009-10-19 10:48 ` Hans-Christian Egtvedt
2009-10-19 10:53 ` Mark Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Hans-Christian Egtvedt @ 2009-10-19 10:48 UTC (permalink / raw)
To: u-boot
On Mon, 19 Oct 2009 11:35:40 +0100
Mark Jackson <mpfj-list@mimc.co.uk> wrote:
> Hans-Christian Egtvedt wrote:
> > On Mon, 19 Oct 2009 10:49:00 +0100
> > Mark Jackson <mpfj-list@mimc.co.uk> wrote:
> >
> >> The portmux peripheral pin selection code used when setting up
> >> the MACB1 ethernet port has a small (but critical !!) typo.
> >>
> >
> > It does? Where is this fixed in the patch?
>
> Not sure what you mean ...
>
Aha, rereading I get it, I thought you were fixing an actual "!!" typo
somewhere in the code.
<snipp>
--
Best regards,
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask
2009-10-19 10:48 ` Hans-Christian Egtvedt
@ 2009-10-19 10:53 ` Mark Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Mark Jackson @ 2009-10-19 10:53 UTC (permalink / raw)
To: u-boot
Hans-Christian Egtvedt wrote:
> On Mon, 19 Oct 2009 11:35:40 +0100
> Mark Jackson <mpfj-list@mimc.co.uk> wrote:
>
>> Hans-Christian Egtvedt wrote:
>>> On Mon, 19 Oct 2009 10:49:00 +0100
>>> Mark Jackson <mpfj-list@mimc.co.uk> wrote:
>>>
>>>> The portmux peripheral pin selection code used when setting up
>>>> the MACB1 ethernet port has a small (but critical !!) typo.
>>>>
>>> It does? Where is this fixed in the patch?
>> Not sure what you mean ...
>>
>
> Aha, rereading I get it, I thought you were fixing an actual "!!" typo
> somewhere in the code.
Ho, ho ... I guess my comment is a bit misleading :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-10-19 10:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-19 9:49 [U-Boot] [PATCH] avr32 portmux : fix incorrect port mask Mark Jackson
2009-10-19 10:10 ` Hans-Christian Egtvedt
2009-10-19 10:35 ` Mark Jackson
2009-10-19 10:48 ` Hans-Christian Egtvedt
2009-10-19 10:53 ` Mark Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox