[U-Boot] [PATCH 1/3] video: mb862xx: add option CONFIG_VIDEO_MB862xx_ACCEL for X888RGB mode

[Wolfgang Grandegger <wg@grandegger.com>]

Wolfgang Denk wrote:
> Dear Wolfgang Grandegger,
> 
> In message <20091019111913.427445638@denx.de> you wrote:
>> The new IPEK01 board uses the X888RGB mode for the Lime graphics
>> controller. For this mode video accelaration does not work. This patch
>> makes the accelaration configurable via CONFIG_VIDEO_MB862xx_ACCEL,
>> which is enabled for the lwmon5 and the socrates board for backward
>> compatibility.
> 
> Why would you want to disable it for IPEK01? Accelaration seems to be
> a good thing you don't give up if you don't have to, but I
> cannot think of reasons why you would have to do without it?

Because acceleration does work with 16 bpp but *not* with 32 bpp. That's
the reason why we made it configurable. Well, this patch could be
dropped, because the BSP for the IPEK01 posted here uses now 16 bpp as well.

>> Index: u-boot-mainline/drivers/video/cfb_console.c
>> ===================================================================
>> --- u-boot-mainline.orig/drivers/video/cfb_console.c	2009-10-19 13:17:14.582303087 +0200
>> +++ u-boot-mainline/drivers/video/cfb_console.c	2009-10-19 13:17:29.406303158 +0200
> 
> Please use git-format-patch to create patches.

Why? Do you have any problems to apply these patches? I personally
(still) prefer using quilt for patch stack management.

>> --- u-boot-mainline.orig/drivers/video/mb862xx.c	2009-10-19 13:17:14.582303087 +0200
>> +++ u-boot-mainline/drivers/video/mb862xx.c	2009-10-19 13:17:17.467553012 +0200
> ...
>> @@ -174,6 +178,14 @@
>>  	DE_WR_FIFO (dev->winSizeY << 16 | dev->winSizeX);
>>  	/* sync with SW access to framebuffer */
>>  	de_wait ();
>> +#else
>> +	unsigned int i, *p;
>> +
>> +	i = dev->winSizeX * dev->winSizeY;
>> +	p = (unsigned int *)dev->frameAdrs;
>> +	while (i--)
>> +		*p++ = 0;
>> +#endif
> 
> Why don't you use memset() here?

Maybe to ensure that D32 accesses are performed. Anatolij might know?

Wolfgang.