From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] video: mb862xx: add option VIDEO_FB_16BPP_WORD_SWAP for IPEK01
Date: Mon, 19 Oct 2009 14:09:08 +0200 [thread overview]
Message-ID: <4ADC56E4.40907@grandegger.com> (raw)
In-Reply-To: <20091019115654.06B6B182FC428@nyx.denx.de>
Wolfgang Denk wrote:
> Dear Wolfgang Grandegger,
>
> In message <20091019111913.621578739@denx.de> you wrote:
>> In 16 bpp mode, the new IPEK01 board only requires swapping of D16 words
>> for D32 accesses due to the diffferent connecting to the GDC bus. This
>> patch introduces the configuration option VIDEO_FB_16BPP_WORD_SWAP,
>> which should be set for all board using the mb862xx in 16 bpp mode. For
>> the IPEK01, VIDEO_FB_16BPP_PIXEL_SWAP should not be set.
>
> I don't see any functional change in this patch - all you do is
> renaming VIDEO_FB_16BPP_PIXEL_SWAP into VIDEO_FB_16BPP_WORD_SWAP.
>
> This makes no sense to me.
Please have a look to the patched file. VIDEO_FB_16BPP_PIXEL_SWAP is
used in other locations as well. This type of swapping is related to the
way the GDC on the Socrates and lwmo5 board is connected.
Wolfgang.
next prev parent reply other threads:[~2009-10-19 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 11:19 [U-Boot] [PATCH 0/3] mpc52xx: IPEK01 board support Wolfgang Grandegger
2009-10-19 11:19 ` [U-Boot] [PATCH 1/3] video: mb862xx: add option CONFIG_VIDEO_MB862xx_ACCEL for X888RGB mode Wolfgang Grandegger
2009-10-19 11:52 ` Wolfgang Denk
2009-10-19 12:06 ` Wolfgang Grandegger
2009-10-19 12:29 ` Wolfgang Denk
2009-10-19 12:46 ` Wolfgang Grandegger
2009-10-19 11:19 ` [U-Boot] [PATCH 2/3] video: mb862xx: add option VIDEO_FB_16BPP_WORD_SWAP for IPEK01 Wolfgang Grandegger
2009-10-19 11:56 ` Wolfgang Denk
2009-10-19 12:09 ` Wolfgang Grandegger [this message]
2009-10-19 12:31 ` Wolfgang Denk
2009-10-19 11:19 ` [U-Boot] [PATCH 3/3] mpc52xx: add support for the IPEK01 board Wolfgang Grandegger
2009-10-19 12:25 ` Wolfgang Denk
2009-10-19 13:42 ` Wolfgang Grandegger
2009-10-19 13:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADC56E4.40907@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox