From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] qemu_mips: Fix CONFIG_NET_MULTI build warning
Date: Mon, 19 Oct 2009 22:04:39 +0900 [thread overview]
Message-ID: <4ADC63E7.4000901@pobox.com> (raw)
eth.c:497:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI
Signed-off-by: Shinya Kuribayashi <skuribay@pobox.com>
---
I have a few concerns about this fix:
First. I'm not sure why CONFIG_NET_MULTI is "undef"ed for qemu_mips,
while CONFIG_DRIVER_NE2000 has been enabled for qemu_mips at an early
stage.
I don't follow recent changes around eth.c and CONFIG_NET_MULTI, but
it's probably CONFIG_NET_MULTI used to be used strictly for multi
ports, isn't it?
Next. As far as looking at drivers/net/ne2000*.[ch], NE2000 driver
doesn't seem to require board_eth_init() or cpu_eth_init(). Right?
Therefore I've not added a corresponding hook in board/qemu_mips/
qemu_mips.c. If my understanding is wrong, please let me know.
include/configs/qemu-mips.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/qemu-mips.h b/include/configs/qemu-mips.h
index cbacdf9..f419174 100644
--- a/include/configs/qemu-mips.h
+++ b/include/configs/qemu-mips.h
@@ -157,7 +157,7 @@
#define CONFIG_ENV_OVERWRITE 1
-#undef CONFIG_NET_MULTI
+#define CONFIG_NET_MULTI
#define MEM_SIZE 128
--
1.6.5.1
next reply other threads:[~2009-10-19 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 13:04 Shinya Kuribayashi [this message]
2009-10-19 16:41 ` [U-Boot] [PATCH] qemu_mips: Fix CONFIG_NET_MULTI build warning Ben Warren
2009-10-19 23:59 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADC63E7.4000901@pobox.com \
--to=skuribay@pobox.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox