From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 21 Oct 2009 20:48:38 -0700 Subject: [U-Boot] [PATCH] Fix DM9000 MAC address handling In-Reply-To: <200910212331.09485.vapier@gentoo.org> References: <1256171109-16654-1-git-send-email-biggerbadderben@gmail.com> <200910212331.09485.vapier@gentoo.org> Message-ID: <4ADFD616.60505@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Wednesday 21 October 2009 20:25:09 Ben Warren wrote: > >> +void dm9000_get_enetaddr(struct eth_device *dev) >> > > static ? > > Yeah, this was thrown together pretty quickly... >> +#if !defined(CONFIG_DM9000_NO_SROM) >> + int i; >> + for (i = 0; i < 3; i++) { >> + dm9000_read_srom_word(i, dev->enetaddr + (2 * i)); >> + } >> > > dont need the braces ... > OK > -mike > thanks for the review, Ben