[U-Boot] blank line repeats last command

[U-Boot] blank line repeats last command

[David Collier]

Now I've turned on command history, if I hit "return" on a blank line it
is the same as hitting up arrow and return - in other words it repeats
the last command.

That isn't helpful behaviour to my mind.

David Collier

www.dexdyne.com

[U-Boot] blank line repeats last command

[Jerry Van Baren]

David Collier wrote:
> Now I've turned on command history, if I hit "return" on a blank line it
> is the same as hitting up arrow and return - in other words it repeats
> the last command.

(for a subset of commands)

> That isn't helpful behaviour to my mind.
> 
> David Collier

That is intentional behavior and has been that way (nearly) forever.  It 
is configured via the command definition macro on a per-command basis. 
"Dangerous" commands do *not* repeat, commands that may be useful to 
repeat (e.g. displaying memory) do.

Hey, you were just complaining that you had to retype the IP address for 
repeated pings - now you are complaining that you don't have to type 
anything to repeat a command.  Make up you mind if you want shortcuts or 
not!  :-P

Best regards,
gvb

[U-Boot] blank line repeats last command

[David Collier]

> That is intentional behavior and has been that way (nearly) 
> forever.  It is configured via the command definition macro on a 
> per-command basis. "Dangerous" commands do *not* repeat, commands 
> that may be useful to repeat (e.g. displaying memory) do.

ah - much more subtle than I was guessing then... if dangerous stuff
doesn't do it, I'm much happier



> Hey, you were just complaining that you had to retype the IP 
> address for repeated pings - now you are complaining that you don't 
> have to type anything to repeat a command.  Make up you mind if you 
> want shortcuts or not!  :-P

:-P back

For my money, I'd want to see what I'd repeated, so I'd have been happy
to have to use up-arrow, enter, rather then just enter.

But my views don't always prevail.

D



> 
> Best regards,
> gvb
> 


David Collier

www.dexdyne.com

[U-Boot] blank line repeats last command

[Jerry Van Baren]

David Collier wrote:

[snip]

> For my money, I'd want to see what I'd repeated, so I'd have been happy
> to have to use up-arrow, enter, rather then just enter.
> 
> But my views don't always prevail.
> 
> D

Command repeating predates the implementation of command line history 
and works even if you don't have command line editing / history enabled.

Also, on commands like memory display, it auto-advances the address so 
that you can hit <return> multiple times to see the next chunk of 
memory.  Command history requires you to edit the address manually to 
get the next chunk.  (FWIIW, I would be happy to see most command 
repeats turned off, but memory display auto-advance is really nice.)

gvb

[U-Boot] blank line repeats last command

[Wolfgang Denk]

Dear "David Collier",

In message <memo.20091023115619.2092P@postmaster+dexdyne.com.cix.co.uk> you wrote:
> Now I've turned on command history, if I hit "return" on a blank line it
> is the same as hitting up arrow and return - in other words it repeats
> the last command.
> 
> That isn't helpful behaviour to my mind.

Please READ THE DOCUMENTATION.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Even if you aren't in doubt, consider the mental welfare of the  per-
son who has to maintain the code after you, and who will probably put
parens in the wrong place.          - Larry Wall in the perl man page

[U-Boot] blank line repeats last command

[Frank Svendsbøe]

On Fri, Oct 23, 2009 at 1:55 PM, Jerry Van Baren <gerald.vanbaren@ge.com> wrote:
> David Collier wrote:
>
> [snip]
>
>> For my money, I'd want to see what I'd repeated, so I'd have been happy
>> to have to use up-arrow, enter, rather then just enter.
>>
>> But my views don't always prevail.
>>
>> D
>
> Command repeating predates the implementation of command line history
> and works even if you don't have command line editing / history enabled.
>
> Also, on commands like memory display, it auto-advances the address so
> that you can hit <return> multiple times to see the next chunk of
> memory. ?Command history requires you to edit the address manually to
> get the next chunk. ?(FWIIW, I would be happy to see most command
> repeats turned off, but memory display auto-advance is really nice.)
>

I partly agree with David Collier on this matter. Before I discovered
this was a feature,
I was sure this was a bug, but I understand some of you reasoning..
just not all. For instance,
I can understand why it's handy when dumping memory, but what's the
rationale behind
having 'cp.b' repeating? It's annoying when writing large files to
slow (NOR) flash.

Best regards,
Frank

> gvb
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] blank line repeats last command

[Scott Wood]

Frank Svendsb?e wrote:
> I partly agree with David Collier on this matter. Before I discovered
> this was a feature,
> I was sure this was a bug, but I understand some of you reasoning..
> just not all. For instance,
> I can understand why it's handy when dumping memory, but what's the
> rationale behind
> having 'cp.b' repeating? It's annoying when writing large files to
> slow (NOR) flash.

Indeed it is.

IMHO, rather than select a few "dangerous" commands to exempt from autorepeat, 
it should be off for most commands and selectively enabled for a handful of 
commands where it's really useful (such as autoincrement dumps).

-Scott

[U-Boot] blank line repeats last command

[Peter Tyser]

On Fri, 2009-10-23 at 13:59 -0500, Scott Wood wrote:
> Frank Svendsb?e wrote:
> > I partly agree with David Collier on this matter. Before I discovered
> > this was a feature,
> > I was sure this was a bug, but I understand some of you reasoning..
> > just not all. For instance,
> > I can understand why it's handy when dumping memory, but what's the
> > rationale behind
> > having 'cp.b' repeating? It's annoying when writing large files to
> > slow (NOR) flash.
> 
> Indeed it is.
> 
> IMHO, rather than select a few "dangerous" commands to exempt from autorepeat, 
> it should be off for most commands and selectively enabled for a handful of 
> commands where it's really useful (such as autoincrement dumps).

+1 - it generally annoys me too:)

Peter